Blender Git Commit Log

Git Commits -> Revision 0767f95

Revision 0767f95 by Sergey Sharybin (master)
June 11, 2019, 13:11 (GMT)
Sound: Fix queries of sound info

A lot of areas were querying sound information directly using audio handle
which does not exist on an original sound IDs.

This change basically makes it so it's possible to query information about
given sound ID, without worrying about whether it's loaded or not: if it is
needed to load it first it happens automatically (no automatically-opened
handles are left behind though).

While this seems a bit extreme to open files on such queries it is still
better than the old situation when all sound handles were opened on file
load, no matter if it's needed or not. Besides, none of the changed code
paths are performance critical, just handful of tools.

Fixes T65696: Sequencer fails to create a new sound sequence strip via Python
Fixes T65656: Audio strip - SHIFT K crashes Blender

Reviewers: brecht

Reviewed By: brecht

Subscribers: ISS

Maniphest Tasks: T65696, T65656

Differential Revision: https://developer.blender.org/D5061

Commit Details:

Full Hash: 0767f95a63959e156c302520db7fbf480159abe0
Parent Commit: 3a6f6c8
Lines Changed: +164, -107

13 Modified Paths:

/source/blender/blenkernel/BKE_nla.h (+3, -1) (Diff)
/source/blender/blenkernel/BKE_sequencer.h (+3, -2) (Diff)
/source/blender/blenkernel/BKE_sound.h (+26, -7) (Diff)
/source/blender/blenkernel/intern/nla.c (+6, -8) (Diff)
/source/blender/blenkernel/intern/scene.c (+1, -1) (Diff)
/source/blender/blenkernel/intern/sequencer.c (+12, -18) (Diff)
/source/blender/blenkernel/intern/sound.c (+79, -41) (Diff)
/source/blender/editors/object/object_add.c (+2, -1) (Diff)
/source/blender/editors/space_nla/nla_edit.c (+2, -1) (Diff)
/source/blender/editors/space_sequencer/sequencer_edit.c (+20, -14) (Diff)
/source/blender/editors/space_sequencer/sequencer_preview.c (+1, -3) (Diff)
/source/blender/makesrna/intern/rna_sequencer.c (+6, -5) (Diff)
/source/blender/makesrna/intern/rna_sequencer_api.c (+3, -5) (Diff)
By: Miika HämäläinenLast update: Nov-07-2014 14:18MiikaHweb | 2003-2021