Blender Git Commit Log

Git Commits -> Revision 2691dd2

Revision 2691dd2 by Bastien Montagne (master)
March 24, 2019, 17:20 (GMT)
Fix T49979: HSV/HSL 'Far' interpolation in colorbands when both stops have same hue.

When two stops had the exact same color, 'Far' interpolation would
behave like the three others and generate constant colors, instead of
generating expected 'full turn' in Hue space.

Note that this will break the 'constant' color between two stops with
same value in the 'Far' interpolation mode, but think that change is
OK/expected.

This fix also exposed that 'early out' case when we are after last stop
was not working properly, still triggering actual interpolation
computation in all cases, thus the refactor in `BKE_colorband_evaluate()`
itself. We also now avoid computing factors in constant case, and get
out early in all interpolation cases but the 'spline' ones (where color
ramping can start before first stop, and end after last one).

Work initiated by patch from Charlie Jolly (@charlie) in T49979, thanks.

Reviewers: brecht, sergey

Subscribers: charlie

Differential Revision: https://developer.blender.org/D4556

Commit Details:

Full Hash: 2691dd28e7dc085d0ae0aef219c433d4521fc326
Parent Commit: b48e679
Lines Changed: +25, -22

By: Miika HämäläinenLast update: Nov-07-2014 14:18 MiikaHweb | 2003-2019