Blender Git Commit Log

Git Commits -> Revision 43046d8

Revision 43046d8 by Gaia Clary (master)
May 17, 2021, 19:10 (GMT)
Collada import: use black for Base Color when missing <diffuse>

Treat a missing <diffuse> the same as a black diffuse color.

The easiest way to see this bug is with a Collada shader like

<color sid="emission">1 0 0 1</color>

The Collada spec says this should be just

color = <emission>

ie. red everywhere. The importer slots the red into the Principled Emission socket, but since it leaves the Base Color as the default off-white, this is added to red, and the material looks white-pink in the light and red only in the shadows.

Putting black in the Base Color makes it look red everywhere.

D10939 will also eliminate the much-less-noticeable specular term for this case.

Reviewed By: gaiaclary

Differential Revision:

Commit Details:

Full Hash: 43046d82b7d18398027afb6b92ea0be7588f08a8
Parent Commit: 542b8da
Lines Changed: +20, -10

1 Modified Path:

/source/blender/io/collada/Materials.cpp (+20, -10) (Diff)
By: Miika HämäläinenLast update: Nov-07-2014 14:18MiikaHweb | 2003-2021