Blender Git Commit Log

Git Commits -> Revision 46eef60

Revision 46eef60 by Bastien Montagne (master)
December 3, 2013, 19:35 (GMT)
Cleanup: Internal degrees removal.

This patch changes most of the reamining degrees usage in internal code into radians.
I let a few which I know off asside, for reasons explained below - and I'm not sure to have found out all of them.

WARNING: this introduces forward incompatibility, which means files saved from this version won't open 100% correctly
in previous versions (a few angle properties would use radians values as degrees...).

Details:
- Data:
-- Lamp.spotsize: Game engine exposed this setting in degrees, to not break the API here I kept it as such
(using getter/setter functions), still using radians internally.
-- Mesh.smoothresh: Didn't touch to this one, as we will hopefully replace it completely by loop normals currently in dev.

- Modifiers:
-- EdgeSplitModifierData.split_angle, BevelModifierData.bevel_angle: Done.

- Postprocessing:
-- WipeVars.angle (sequencer's effect), NodeBokehImage.angle, NodeBoxMask.rotation, NodeEllipseMask.rotation: Done.

- BGE:
-- bConstraintActuator: Orientation type done (the minloc[0] & maxloc[0] cases). Did not touch to 'limit location' type,
it can also limit rotation, but it exposes through RNA the same limit_min/limit_max, which hence
can be either distance or angle values, depending on the mode. Will leave this to BGE team.
-- bSoundActuator.cone_outer_angle_3d, bSoundActuator.cone_inner_angle_3d: Done (note I kept degrees in BGE itself,
as it seems this is the expected value here...).
-- bRadarSensor.angle: Done.

Reviewers: brecht, campbellbarton, sergey, gaiaclary, dfelinto, moguri, jbakker, lukastoenne, howardt

Reviewed By: brecht, campbellbarton, sergey, gaiaclary, moguri, jbakker, lukastoenne, howardt
Thanks to all!

Differential Revision: https://developer.blender.org/D59

Commit Details:

Full Hash: 46eef60d93fd0d52ed4b94750f7a3248db5594ee
Parent Commit: 4627516
Lines Changed: +184, -152

29 Modified Paths:

/source/blender/blenkernel/BKE_blender.h (+1, -1) (Diff)
/source/blender/blenkernel/intern/camera.c (+1, -1) (Diff)
/source/blender/blenkernel/intern/lamp.c (+1, -1) (Diff)
/source/blender/blenkernel/intern/sca.c (+3, -2) (Diff)
/source/blender/blenkernel/intern/seqeffects.c (+2, -2) (Diff)
/source/blender/blenloader/intern/versioning_260.c (+82, -1) (Diff)
/source/blender/collada/DocumentImporter.cpp (+2, -1) (Diff)
/source/blender/collada/LightExporter.cpp (+2, -2) (Diff)
/source/blender/compositor/nodes/COM_DefocusNode.cpp (+1, -1) (Diff)
/source/blender/compositor/operations/COM_BokehImageOperation.cpp (+1, -1) (Diff)
/source/blender/compositor/operations/COM_BoxMaskOperation.cpp (+1, -1) (Diff)
/source/blender/compositor/operations/COM_EllipseMaskOperation.cpp (+1, -1) (Diff)
/source/blender/editors/space_node/drawnode.c (+2, -2) (Diff)
/source/blender/editors/space_view3d/drawobject.c (+1, -1) (Diff)
/source/blender/gpu/intern/gpu_draw.c (+1, -1) (Diff)
/source/blender/gpu/intern/gpu_material.c (+6, -6) (Diff)
/source/blender/makesrna/intern/rna_actuator.c (+11, -12) (Diff)
/source/blender/makesrna/intern/rna_lamp.c (+2, -17) (Diff)
/source/blender/makesrna/intern/rna_modifier.c (+5, -42) (Diff)
/source/blender/makesrna/intern/rna_nodetree.c (+11, -12) (Diff)
/source/blender/makesrna/intern/rna_sensor.c (+4, -4) (Diff)
/source/blender/makesrna/intern/rna_sequencer.c (+2, -25) (Diff)
/source/blender/modifiers/intern/MOD_bevel.c (+2, -2) (Diff)
/source/blender/modifiers/intern/MOD_edgesplit.c (+2, -2) (Diff)
/source/blender/render/intern/source/convertblender.c (+2, -2) (Diff)
/source/gameengine/Converter/KX_ConvertActuators.cpp (+5, -5) (Diff)
/source/gameengine/Converter/KX_ConvertSensors.cpp (+1, -1) (Diff)
/source/gameengine/Ketsji/KX_Light.cpp (+27, -3) (Diff)
/source/gameengine/Ketsji/KX_Light.h (+2, -0) (Diff)
By: Miika HämäläinenLast update: Nov-07-2014 14:18MiikaHweb | 2003-2021