Blender Git Commit Log

Git Commits -> Revision 4e6975f

Revision 4e6975f by Bastien Montagne (master)
July 29, 2020, 15:36 (GMT)
Fix T78285: Invalid thread safety in shrinkwrap modifier code.

This uses mesh's runtime mutex for both `BKE_mesh_runtime_looptri_ensure`
(was using its own global RW mutex before), and `BKE_mesh_wrapper_ensure_mdata`
(was not protected at all before).

This is more like a band-aid than a proper fix, as mentioned in the report
proper fix would be for the modifier to request those data (the relevant
BVHTree, which would implicitely also call the tow others) through flags,
just like it does for regular CDData layers. But this is a much bigger
refactor to be done outside of bugfix scope.

Reviewed By: sergey

Maniphest Tasks: T78285

Differential Revision: https://developer.blender.org/D8415

Commit Details:

Full Hash: 4e6975ffd6656fb9abbaa577fef0815666c6c808
Parent Commit: 54a2fcc
Lines Changed: +15, -11

2 Modified Paths:

/source/blender/blenkernel/intern/mesh_runtime.c (+7, -11) (Diff)
/source/blender/blenkernel/intern/mesh_wrapper.c (+8, -0) (Diff)
By: Miika HämäläinenLast update: Nov-07-2014 14:18MiikaHweb | 2003-2021