Blender Git Commit Log
Git Commits -> Revision 5184476
Revision 5184476 by Dalai Felinto (master) September 11, 2011, 05:54 (GMT) |
bugfix: [bf-blender-Game Engine][28167] Restart game actuator don't get changed material mode http://projects.blender.org/tracker/?func=detail&aid=28167&group_id=9&atid=306 Game Actuator (restart or load a new file) will not keep some settings alive (as we had in 2.49). In 2.49 the solution used was to use Blender globals (G.fileflags) to get/set those settings. That was causing the blender file to change if you change the material mode from the game. In 2.5 this never worked, and the implementation was buggy (it's relying in the scene settings, which get reset ever time we restart/load a new file). My idea for fixing this is to create a new struct (GlobalSettings) where we store any setting to be preserver during the course of the game. This is specially important for options that require the game to restart/load new file (graphic ones). But it later can be expanded to support other things such as audio settings (e.g. volume), ... I'm also planning to expand it for stereo and dome settings, but I prefer to first get this committed and then build a new patch on top of that. I had some problems in finding a correct way for build/link the blenderplayer changes, so although it's working I'm not sure this is the best code (e.g. I couldn't make forward declaration to work in GPG_Application.h for the struct GlobalSettings so I ended up including KX_KetsjiEngine.h) [note: I talked with Brecht and he find this is an ok solution. He implemented it originally so it's good to have his go. However I still think there must be a way to make forward declaration to work. I will see with other devs if there is a better solution] [also I'm likely renaming glsl to flags later if there are more settings stored in the flags to be used. But for now we are only handling glsl flags] |
Commit Details:
Full Hash: 5184476fe1bd6c61a50a047bdba1f4b9756f323c
SVN Revision: 40113
Parent Commit: cfa83b0
Lines Changed: +82, -25
7 Modified Paths:
/source/gameengine/BlenderRoutines/BL_KetsjiEmbedStart.cpp (+12, -3) (Diff)
/source/gameengine/GamePlayer/ghost/GPG_Application.cpp (+16, -4) (Diff)
/source/gameengine/GamePlayer/ghost/GPG_Application.h (+6, -1) (Diff)
/source/gameengine/GamePlayer/ghost/GPG_ghost.cpp (+12, -2) (Diff)
/source/gameengine/Ketsji/KX_KetsjiEngine.cpp (+10, -0) (Diff)
/source/gameengine/Ketsji/KX_KetsjiEngine.h (+12, -1) (Diff)
/source/gameengine/Ketsji/KX_PythonInit.cpp (+14, -14) (Diff)
/source/gameengine/GamePlayer/ghost/GPG_Application.cpp (+16, -4) (Diff)
/source/gameengine/GamePlayer/ghost/GPG_Application.h (+6, -1) (Diff)
/source/gameengine/GamePlayer/ghost/GPG_ghost.cpp (+12, -2) (Diff)
/source/gameengine/Ketsji/KX_KetsjiEngine.cpp (+10, -0) (Diff)
/source/gameengine/Ketsji/KX_KetsjiEngine.h (+12, -1) (Diff)
/source/gameengine/Ketsji/KX_PythonInit.cpp (+14, -14) (Diff)