Blender Git Commit Log

Git Commits -> Revision 5472ae6

Revision 5472ae6 by Bastien Montagne (master)
January 17, 2020, 18:59 (GMT)
Fix memory leak when full-copying a scene after recent changes.

Once again, am not exactly sure why that was working before, and not
anymore - but in any case, doing that kind of update here is not only
useless (since we have to do it at the end of the whole
collections/objects duplication and remapping anyway), it is also rather
dangerous, as collections are currently in rather invalid states at that
point of the code...

Note that in ideal world, `BKE_main_collection_sync()` & co would be
lazy (setting only a flag, then code actually needing this to be valid
again should call some sort of `BKE_main_collection_sync_ensure()`).
Then we would not have to worry about such things (and we'd get nice
performance improvements in some cases, also in main remapping code,
etc.).

Food for some refactoring, some day...

Commit Details:

Full Hash: 5472ae6fdff67ea26d0f9d6f76da02bcd106faf9
Parent Commit: 6744f4d
Lines Changed: +12, -1

3 Modified Paths:

/source/blender/blenkernel/BKE_collection.h (+2, -0) (Diff)
/source/blender/blenkernel/intern/collection.c (+5, -0) (Diff)
/source/blender/editors/object/object_relations.c (+5, -1) (Diff)
By: Miika HämäläinenLast update: Nov-07-2014 14:18MiikaHweb | 2003-2021