Blender Git Commit Log

Git Commits -> Revision 726bc3a

Revision 726bc3a by Sergey Sharybin (master)
November 25, 2021, 09:17 (GMT)
Fix T93155: Approximate shadow catcher displayed wrong on CPU and GPU

Was happening during rendering, causing visual artifacts when doing
CPU+GPU rendering, and giving different in-progress results on different

The root of the issue comes to the fact that math used in the approximate
shadow catcher calculation might have resulted in negative alpha channel,
and negative values for display are handled differently on CPU and GPU.
Such difference in handling is caused by an approximate conversion used on
the CPU for the performance reasons.

This change makes it so no negative alpha is generated by the approximate
shadow catcher. Not sure if we need some explicit clamping somewhere to
deal with possible negative values coming from somewhere else.

The shadow catcher cornell box tests are to be updated for the new code,
but the new result seems to be more accurate.

Differential Revision:

Commit Details:

Full Hash: 726bc3a46b2fcf6ba36c3e3484b344340f83e53e
Parent Commit: ce5561b
Lines Changed: +1, -1

1 Modified Path:

/intern/cycles/kernel/film/read.h (+1, -1) (Diff)
By: Miika HämäläinenLast update: Nov-07-2014 14:18MiikaHweb | 2003-2021