Blender Git Commit Log

Git Commits -> Revision 78d1aa4

Revision 78d1aa4 by Sybren A. Stüvel (master)
October 15, 2020, 12:04 (GMT)
Cleanup: Animation, simplify channel selection code

Split up `ANIM_deselect_anim_channels()` into
`ANIM_anim_channels_select_set()` and
`ANIM_anim_channels_select_toggle()`.

`ANIM_anim_channels_select_set()` is equivalent to the old
`ANIM_deselect_anim_channels(..., false, ACHANNEL_SETFLAG_xxx)`.

`ANIM_anim_channels_select_toggle()` is equivalent to the old
`ANIM_deselect_anim_channels(..., true, ACHANNEL_SETFLAG_ADD)`.

`ANIM_deselect_anim_channels(..., true, ACHANNEL_SETFLAG_CLEAR)` was
also called once. The `true` parameter suggested the "toggle" behaviour
was intended, but the `ACHANNEL_SETFLAG_CLEAR` argument prevented any
toggling. This is now replaced with `ANIM_anim_channels_select_set(ac,
ACHANNEL_SETFLAG_CLEAR)` to make this explicit.

No functional changes, just a cleanup in order to better understand how
the selection works.

Commit Details:

Full Hash: 78d1aa4d521cff25b07af2f6f8790d51b8b26064
Parent Commit: 1ec1e36
Lines Changed: +130, -111

7 Modified Paths:

/source/blender/editors/animation/anim_channels_edit.c (+116, -99) (Diff)
/source/blender/editors/include/ED_anim_api.h (+5, -3) (Diff)
/source/blender/editors/screen/screen_ops.c (+1, -1) (Diff)
/source/blender/editors/space_action/action_select.c (+3, -3) (Diff)
/source/blender/editors/space_graph/graph_select.c (+1, -1) (Diff)
/source/blender/editors/space_nla/nla_channels.c (+3, -3) (Diff)
/source/blender/editors/space_nla/nla_select.c (+1, -1) (Diff)
By: Miika HämäläinenLast update: Nov-07-2014 14:18MiikaHweb | 2003-2021