Blender Git Commit Log

Git Commits -> Revision 8c3d42b

Revision 8c3d42b by Kévin Dietrich (master)
October 29, 2020, 16:39 (GMT)
Fix T82129: Cycles "Persistent Images" incorrectly retains scene data

The issue stems from the fact that scene arrays are not cleared when rendering is done. This was not really an issue before the introduction of the ownership system (rB429afe0c626a) as the id_map would recreate scene data arrays based on their new content. However, now that the id_maps do not have access to the scene data anymore the arrays are never created.

Another related issue is that the BlenderSync instance is never freed when the persistent data option is activated.

To fix this, we delete nodes created by the id_maps in their destructors, and delete the BlenderSync instance before creating a new one, so the id_maps destructors are actually called.

Reviewed By: brecht

Maniphest Tasks: T82129

Differential Revision: https://developer.blender.org/D9378

Commit Details:

Full Hash: 8c3d42bd0f0160ba58c6a932c0e4c228ce6b0426
Parent Commit: 2e41db5
Lines Changed: +114, -26

9 Modified Paths:

/intern/cycles/blender/blender_id_map.h (+20, -8) (Diff)
/intern/cycles/blender/blender_light.cpp (+3, -3) (Diff)
/intern/cycles/blender/blender_object.cpp (+5, -5) (Diff)
/intern/cycles/blender/blender_particles.cpp (+1, -2) (Diff)
/intern/cycles/blender/blender_session.cpp (+1, -0) (Diff)
/intern/cycles/blender/blender_shader.cpp (+2, -2) (Diff)
/intern/cycles/blender/blender_sync.cpp (+6, -6) (Diff)
/intern/cycles/render/scene.cpp (+54, -0) (Diff)
/intern/cycles/render/scene.h (+22, -0) (Diff)
By: Miika HämäläinenLast update: Nov-07-2014 14:18MiikaHweb | 2003-2021