Blender Git Commit Log

Git Commits -> Revision a0acb9b

Revision a0acb9b by Bastien Montagne (master)
November 25, 2021, 09:21 (GMT)
Fix T91444: Edge Loop Preview fails with two Mirror Modifiers

The mirror modifiers merge option caused unnecessary re-ordering
to the vertex array with original vertices merging into their copies.

While this wasn't an error, it meant creating a 1:1 mapping from input
vertices to their final output wasn't reliable (when looping over
vertices first to last) as is done in
BKE_editmesh_vert_coords_when_deformed.

As merging in either direction is supported, keep the source meshes
vertices in-order since it allows the vertex coordinates to be extracted.

NOTE: Since this change introduce issues for some cases (e.g. bound
modifiers like SurfaceDeform), this change is only applied to newly
created modifiers, existing ones will still use the old incorrect merge
behavior.

Reviewed By: @brecht

Maniphest Tasks: T93321, T91444

Differential Revision: https://developer.blender.org/D13355

Commit Details:

Full Hash: a0acb9bd0cc049b7b8b941b251c42684b4a0f274
Parent Commit: e6cd476
Lines Changed: +69, -22

6 Modified Paths:

/source/blender/blenkernel/BKE_mesh_mirror.h (+6, -4) (Diff)
/source/blender/blenkernel/intern/mesh_mirror.c (+44, -13) (Diff)
/source/blender/editors/object/object_remesh.cc (+2, -1) (Diff)
/source/blender/makesdna/DNA_modifier_defaults.h (+1, -0) (Diff)
/source/blender/makesdna/DNA_modifier_types.h (+9, -1) (Diff)
/source/blender/modifiers/intern/MOD_mirror.c (+7, -3) (Diff)
By: Miika HämäläinenLast update: Nov-07-2014 14:18MiikaHweb | 2003-2021