Blender Git Commit Log

Git Commits -> Revision aa7051c

Revision aa7051c by Sergey Sharybin (master)
November 29, 2021, 15:59 (GMT)
Fix T93439: Armature widgets from hidden collections are invisible

The are few things in the dependency graph which lead to the issue:
- IDs are only built once.
- Object-data level (Armature, i,e,) builder dependent on the object
visibility.

This caused issues when an armature is first built as not directly
visible (via driver, i.e.) and then was built as a directly visible.
This did not update visibility flag on the node for the custom shape
object.

The idea behind the fix is to go away form passing object visibility
flag to the geometry-level builders and instead rely on the common
visibility flush post-processing to make sure certain objects are
fully visible when needed.

This is the safest minimal part of the change for 3.0 release which
acts as an additional way to ensure visibility. This means that it
might not be a complete fix (if some configuration was overseen) but
it should not make currently working cases to not work.

The fix should also make modifiers used on rigify widgets to work.

The more complete fix will have `is_object_visible` argument removed
from the geometry-level builder functions.

Differential Revision: https://developer.blender.org/D13404

Commit Details:

Full Hash: aa7051c8f21a6b7e2b413b40317502e69764fa05
Parent Commit: dae9917
Lines Changed: +103, -9

11 Modified Paths:

/source/blender/depsgraph/intern/builder/deg_builder.cc (+16, -1) (Diff)
/source/blender/depsgraph/intern/builder/deg_builder_nodes.cc (+23, -8) (Diff)
/source/blender/depsgraph/intern/builder/deg_builder_relations.cc (+7, -0) (Diff)
/source/blender/depsgraph/intern/builder/deg_builder_relations.h (+5, -0) (Diff)
/source/blender/depsgraph/intern/builder/deg_builder_relations_rig.cc (+7, -0) (Diff)
/source/blender/depsgraph/intern/debug/deg_debug_relations_graphviz.cc (+1, -0) (Diff)
/source/blender/depsgraph/intern/depsgraph_query_foreach.cc (+6, -0) (Diff)
/source/blender/depsgraph/intern/node/deg_node.cc (+10, -0) (Diff)
/source/blender/depsgraph/intern/node/deg_node.h (+16, -0) (Diff)
/source/blender/depsgraph/intern/node/deg_node_component.cc (+2, -0) (Diff)
/source/blender/depsgraph/intern/node/deg_node_component.h (+10, -0) (Diff)
By: Miika HämäläinenLast update: Nov-07-2014 14:18MiikaHweb | 2003-2021