Blender Git Commit Log

Git Commits -> Revision b5c629e

January 1, 2018, 14:54 (GMT)
Cycles: Fix possible race condition when generating Beckmann table

Two issues here:

- Checking table size to be non-zero is not a proper way to go here. This is
because we first resize the table and then fill it in. So it was possible that
non-initialized table was used.

Trickery with using temporary memory and then doing table.swap() might work,
but we can not guarantee that table size will be set after the data pointer.

- Mutex guard was useless, because every thread was using own mutex. Need to
make mutex guard static so all threads are using same mutex.

Commit Details:

Full Hash: b5c629e604d9d6cad3e41d86afb2c786acf6dd98
Parent Commit: 89de073
Committed By: Bastien Montagne
Lines Changed: +7, -3

2 Modified Paths:

/intern/cycles/render/shader.cpp (+5, -2) (Diff)
/intern/cycles/render/shader.h (+2, -1) (Diff)
By: Miika HämäläinenLast update: Nov-07-2014 14:18MiikaHweb | 2003-2021