Blender Git Commit Log

Git Commits -> Revision c6e3a20

Revision c6e3a20 by Bastien Montagne (master)
February 13, 2019, 14:02 (GMT)
Fix T61506: Wrong user counting with ID properties in pynodes.

Nuke away old nodeCopyNode(), much better to use new BKE_node_copy_ex(),
which behaves as expected for the various optional flags that can be passed.

This also removes the need to handle ID refcounting in calling code
(ugly!) and allows us to remove an even uglier name from our codebase! :D

Note that this fixes three related issues actually, that bug was also
affecting copy/paste of nodes, and 'Separate with copy' operator (the
latter being actually fully wrong, since it was not refcounting
anything, not even node->id pointer...).

Commit Details:

Full Hash: c6e3a20ab60ba8fb56886913a5c7a4269d45b4c3
Parent Commit: 74a3d9b
Lines Changed: +11, -20

3 Modified Paths:

/source/blender/blenkernel/BKE_node.h (+0, -1) (Diff)
/source/blender/editors/space_node/node_edit.c (+7, -15) (Diff)
/source/blender/editors/space_node/node_group.c (+4, -4) (Diff)
By: Miika HämäläinenLast update: Nov-07-2014 14:18MiikaHweb | 2003-2021