Blender Git Commit Log

Git Commits -> Revision d16386e

Revision d16386e by Sergey Sharybin (master)
March 1, 2019, 18:03 (GMT)
Fix T62087: Crash when rendering in Cycles

The issue was discovered only after recent changes, but roots back
to much older changes.

What was happening is scene's ID recalc flags where never cleared,
which caused ensure_view_layer() to always run copy-on-write on the
scene. This resulted in certain runtime data being cleared, without
proper flag stored in the dependency graph.

This was caused by ID recalc clear function checking whether any ID
was tagged for recalc in that graph or not. This was happening due
to all areas using DEG_id_type_tag() which can only set flags on the
graph from viewport scenes, and could not inform render dependency
graph.

Now ID tyoe tagging is happening on per-graph level, which avoids
possibility of flags running out of sync.

In a bit longer term we also need to get rid of two functions which
are clearing flags: DEG_id_type_tag() and deg_graph_clear_tags().

Commit Details:

Full Hash: d16386e50bc104f9446a30e041a7b74f38b51ae9
Parent Commit: faec365
Lines Changed: +23, -16

3 Modified Paths:

/source/blender/depsgraph/DEG_depsgraph.h (+1, -0) (Diff)
/source/blender/depsgraph/intern/depsgraph_tag.cc (+18, -12) (Diff)
/source/blender/depsgraph/intern/eval/deg_eval_flush.cc (+4, -4) (Diff)
By: Miika HämäläinenLast update: Nov-07-2014 14:18MiikaHweb | 2003-2021