Blender Git Commit Log

Git Commits -> Revision d6d101f

Revision d6d101f by Sergey Sharybin (master)
January 22, 2019, 10:57 (GMT)
Fix T59395: Subdivision modifier with quality 1 crashes blender

This is actually a workaround for the crash in OpenSubdiv.
Topology refiner will have a crash when special conditions
are met:

- Refiner is configured to use infinitely sharp patches.
- Refinement happens for the level 1 (which we call Quality 1 on
Blender side).
- Mesh has non-quad faces.

The workaround is to force refinement to happen to level 2 (or
quality 2 on Blender side) when those conditions are met.

Later on with the next OpenSubdiv update we can remove this
workaround, since there was work done on OpenSubdiv side to
deal better with such configurations.

The modifier will now be somewhat slower, but this will be
compensated with upcoming topology cache enabled by default.

The workaround is done when initializing settings, so the
comparison of topology refiner settings is happening without
any extra workarounds there.

Commit Details:

Full Hash: d6d101feca09ae17af00f080a76acbc4d6785c3e
Parent Commit: fef20d9
Lines Changed: +28, -0

4 Modified Paths:

/source/blender/blenkernel/BKE_subdiv.h (+3, -0) (Diff)
/source/blender/blenkernel/intern/subdiv.c (+23, -0) (Diff)
/source/blender/modifiers/intern/MOD_multires.c (+1, -0) (Diff)
/source/blender/modifiers/intern/MOD_subsurf.c (+1, -0) (Diff)
By: Miika HämäläinenLast update: Nov-07-2014 14:18MiikaHweb | 2003-2021