Blender Git Commit Log

Git Commits -> Revision d7c51aa

Revision d7c51aa by Ton Roosendaal (master)
January 1, 2011, 13:49 (GMT)
Bugfix #25437

Crash in Bezier animation (inserting keys on control points in
curve object). The animation rna paths were not fixed after an
editmode session, which got fixed 2 weeks ago, but for all older
binaries the issue can still pop up.

The crash happened because the RNA array-itterator was not doing
a boundary check, even whilst the array size was passed on to the
itterator callbacks. With rna then writing far outside of valid
memory, very bad and unpredictable corruptions happen.

I've added a range check now, and a decent print to denote the
issue. An assert quit is useless, since a tab-tab on curve objects
will fix the channels nicely.

Example of warning print:
Array itterator out of range: Spline_bezier_points_lookup_int (index 30 range 2)


Commit Details:

Full Hash: d7c51aa3eb50fd173664b724c1d289f3faf989cd
SVN Revision: 33986
Parent Commit: 7040c89
Lines Changed: +8, -2

3 Modified Paths:

/source/blender/makesrna/intern/makesrna.c (+5, -1) (Diff)
/source/blender/makesrna/intern/rna_access.c (+2, -1) (Diff)
/source/blender/makesrna/intern/rna_internal.h (+1, -0) (Diff)
By: Miika HämäläinenLast update: Nov-07-2014 14:18MiikaHweb | 2003-2021