Blender Git Commit Log

Git Commits -> Revision dc8832a

Revision dc8832a by Ton Roosendaal (master)
September 5, 2013, 13:03 (GMT)
Bugfix #35920

Adding a new node in Node Editor failed for "High DPI" (Only Mac retina now).

- Py script for adding nodes was doing dpi magic, which it shouldn't. It has
been replaced with a (temporary) API call to set the correct cursor location.
(Thanks to Lukas T for helping here)

- The SpaceNode->cursor[2] property now is *only* storing the coordinate
in "adding new node space". Use of this has been removed from the code where
possible, with as only exception the code to draw noodles while adding them.

Special coder note: Nodes should respect the DPI value, and draw larger with
larger buttons if you increase this size. The hack here is that this can only
work nice if also the node positions are scaled accordingly.

A better fix could be to check on scaling the node view itself for it. That
then would also remove this Python API call that was added in this commit.
However, that again might fight with how buttons layout code works now...
needs some careful checking.

Commit Details:

Full Hash: dc8832ac92b3640f7dcb784086417da925c9e721
SVN Revision: 59835
Parent Commit: 69b68ed
Lines Changed: +92, -77

10 Modified Paths:

/release/scripts/startup/bl_operators/ (+2, -6) (Diff)
/source/blender/editors/space_node/drawnode.c (+11, -2) (Diff)
/source/blender/editors/space_node/node_add.c (+2, -10) (Diff)
/source/blender/editors/space_node/node_draw.c (+15, -8) (Diff)
/source/blender/editors/space_node/node_edit.c (+5, -17) (Diff)
/source/blender/editors/space_node/node_intern.h (+2, -2) (Diff)
/source/blender/editors/space_node/node_relationships.c (+19, -21) (Diff)
/source/blender/editors/space_node/node_select.c (+6, -9) (Diff)
/source/blender/editors/space_node/space_node.c (+7, -1) (Diff)
/source/blender/makesrna/intern/rna_space.c (+23, -1) (Diff)
By: Miika HämäläinenLast update: Nov-07-2014 14:18MiikaHweb | 2003-2021