Blender Git Commit Log

Git Commits -> Revision e6f0b60

Revision e6f0b60 by Julian Eisel (master)
September 4, 2020, 19:26 (GMT)
UI Code Quality: Use derived struct for number buttons

For the man rationale behind this design, see 49f088e2d093. Further,
this removes users of uiBut.a1/uiBut.a2, which is a very ugly design
choice (hard to reason about).

Note that I had to do rather ugly, specific exceptions for the number
buttons in `ui_def_but_rna()`. But once all users of a1/a2 are removed,
this special handling shouldn't be needed anymore.
I also had to move a sanity check out of the button definition. It's now
moved into a new debug only sanity checking function executed when
finishing the layout definition (block end).

Commit Details:

Full Hash: e6f0b60c2e9111af1878d31dcc295c59ed1bea77
Parent Commit: 4788179
Lines Changed: +788, -604

12 Modified Paths:

/source/blender/editors/animation/fmodifier_ui.c (+106, -92) (Diff)
/source/blender/editors/include/UI_interface.h (+3, -0) (Diff)
/source/blender/editors/interface/interface.c (+74, -16) (Diff)
/source/blender/editors/interface/interface_handlers.c (+18, -8) (Diff)
/source/blender/editors/interface/interface_intern.h (+8, -2) (Diff)
/source/blender/editors/interface/interface_layout.c (+12, -3) (Diff)
/source/blender/editors/interface/interface_templates.c (+136, -116) (Diff)
/source/blender/editors/interface/interface_utils.c (+1, -1) (Diff)
/source/blender/editors/space_clip/clip_buttons.c (+160, -140) (Diff)
/source/blender/editors/space_graph/graph_buttons.c (+12, -12) (Diff)
/source/blender/editors/space_view3d/view3d_buttons.c (+226, -188) (Diff)
/source/blender/editors/uvedit/uvedit_buttons.c (+32, -26) (Diff)
By: Miika HämäläinenLast update: Nov-07-2014 14:18MiikaHweb | 2003-2021