Blender Git Commit Log

Git Commits -> Revision f565620

Revision f565620 by Patrick Mours (master)
November 10, 2021, 14:49 (GMT)
Fix T92985: CUDA errors with Cycles film convert kernels

rB3a4c8f406a3a3bf0627477c6183a594fa707a6e2 changed the macros that create the film
convert kernel entry points, but in the process accidentally changed the parameter definition
to one of those (which caused CUDA launch and misaligned address errors) and changed the
implementation as well. This restores the correct implementation from before.

In addition, the `ccl_gpu_kernel_threads` macro did not work as intended and caused the
generated launch bounds to end up with an incorrect input for the second parameter (it was
set to "thread_num_registers", rather than the result of the block number calculation). I'm
not entirely sure why, as the macro definition looked sound to me. Decided to simply go with
two separate macros instead, to simplify and solve this.

Also changed how state is captured with the `ccl_gpu_kernel_lambda` macro slightly, to avoid
a compiler warning (expression has no effect) that otherwise occurred.

Maniphest Tasks: T92985

Differential Revision: https://developer.blender.org/D13175

Commit Details:

Full Hash: f56562043521a5c160585aea3f28167b4d3bc77d
Parent Commit: a6e4cb0
Lines Changed: +62, -81

5 Modified Paths:

/intern/cycles/kernel/CMakeLists.txt (+0, -1) (Diff)
/intern/cycles/kernel/device/cuda/config.h (+5, -12) (Diff)
/intern/cycles/kernel/device/gpu/kernel.h (+48, -53) (Diff)
/intern/cycles/kernel/device/hip/config.h (+5, -12) (Diff)
/intern/cycles/kernel/device/metal/compat.h (+4, -3) (Diff)
By: Miika HämäläinenLast update: Nov-07-2014 14:18MiikaHweb | 2003-2021