Blender Git Commits

Blender Git "master" branch commits.

Revision dcef3c3 by LazyDodo
1 day and 4 hours ago
build_depenencies: Fix url for openal.
1 day and 6 hours ago
Fix T57284: poor result UV unwrapping concave n-gon.
1 day and 13 hours ago
Fix error disabling all addons
October 18, 2018, 18:21 (GMT)
Fix Copy Selection to Buffer breaking library paths.

This is a bug experienced by animators in the Blender Studio that developers
have been trying to fix for a /long/ time.

What happens is that partial file writing extracts the needed datablocks from
the main list of datablocks into a smaller one. Afterwards they are added back
to the main list, but in some cases not exactly in the same order.

There is file path remapping code that depends on the datablocks being in
exactly the same order as before, and when this was not the case filepaths
would get swapped between datablocks

The reason datablocks are not restored in the same order is because the sorting
of datablocks by name is a) case insensitive and b) undefined if there are
multiple datablocks with the same name from different libraries. This should
be made well defined, but the fix in this commit is simpler.

The way animators ran into this bug is that they use the Copy Attributes addon
a lot, which has as the first item in the menu Copy Selection to Buffer. In
some cases this would be clicked accidentally when menu is near the edge of the
window, breaking the library paths which would only be noticed a much later on
file save and reload.

The way this bug was finally tracked down is that it was suspected that the
undo system was the cause, and so Bastien added library validation for undo.
When Hjalti then did undo and noticed the error, he remembered accidentally
clicking Copy Selection to Buffer just before, and we could finally reproduce
the bug.
October 17, 2018, 14:43 (GMT)
DEBUG_IO: add sanity check on libdata in undo step as well.

There are serious suspicions that weird corruptions faced by studio
artists may happen in undo/redo code, so let's see whether that's the

With this, and when --debug-io arg is passed on startup, the whole lib
data are checked at every undo. This makes undo slower (from two to
three times slower), but it could help us spot better what happens...
October 17, 2018, 14:42 (GMT)
Expose 'debug_io' flag in
October 17, 2018, 14:42 (GMT)
Minor style cleanup.
October 17, 2018, 00:24 (GMT)
Fix cmake not triggering rebuild on .glsl changes

At least on windows we do not re-run datatoc when the .glsl files change.

To test is simple, just change edit_mesh_overlay_common_lib.glsl
remove lines, write plain text, ..., now rebuild and go in edit mode
with the default cube.

I also had to remove the entry in gpu/CMakeLists.txt for
gpu_shader_material.glsl since this was being tracked directly, as well
as running data_to_c_simple (otherwise CMake raises an error for
duplicated entries).

We probably want to do the same for the other datatoc functions.

Reviewers: LazyDodo, brecht
Differential Revision:
October 10, 2018, 22:36 (GMT)
Fix incorrect strncpy use

Didn't ensure null terminated.
October 10, 2018, 22:03 (GMT)
Cleanup: style (pointers)
October 8, 2018, 22:29 (GMT)
Cleanup: spelling
October 8, 2018, 22:14 (GMT)
Cycles: Fix NLM denoising kernels zeroing the wrong buffer on OpenCL

Since my temporary buffer commit (about a month ago), the OpenCL device was zeroing the wrong buffer, leading to
completely wrong filtered feature passes and therefore significantly lower-quality results than CPU and CUDA.
October 8, 2018, 20:58 (GMT)
Cleanup: style
October 8, 2018, 20:49 (GMT)
Fix T57103: Subdivide smooth results in NAN verts
October 8, 2018, 20:22 (GMT)
Cycles: Clean up extra minus in previous commit

Forgot to add that change, sorry for the noise.
October 8, 2018, 20:17 (GMT)
Cycles: Reuse existing buffer in the NLM denoising kernels on CPU
October 8, 2018, 20:13 (GMT)
Cycles: Use existing shared temporary memory in reconstruction step of the denoiser

Previously the code allocated its own temporary memory, but it's possible to just use the existing shared one instead.
October 6, 2018, 20:12 (GMT)
Tests: Support parallel execution of render tests

Previously, parallel tests would overwrite each others temporary outputs.
October 6, 2018, 19:49 (GMT)
Cycles: Implement vectorized NLM kernels for faster CPU denoising
October 4, 2018, 11:34 (GMT)
Fix T57059: "make deps" build error when sndio library is present.
By: Miika HämäläinenLast update: Nov-07-2014 14:18 MiikaHweb | 2003-2018