December 29, 2021, 18:37 (GMT)
Cleanup: Remove unused DerivedMesh functions
December 29, 2021, 17:31 (GMT)
Geometry Nodes: Support instances in the delete geometry node
Ever since the instance domain was added, this was exposed, it just
didn't do anything. This patch implements the instances domain in the
delete and separate geometry nodes, where it acts on the top-level
We act on a mutable instances input, with the idea that eventually
copy on write attribute layers will make this less expensive. It also
allows us to keep the instance references in place and to do less
work in some situations.
Differential Revision: https://developer.blender.org/D13565
December 29, 2021, 16:25 (GMT)
Geometry Nodes: Accumulate Fields Node
This function node creates a running total of a given Vector, Float, or
- Value: The field to be accumulated
- Group Index: The values of this input are used to aggregate the input
into separate 'bins', creating multiple accumulations.
- Leading and Trailing: Returns the running totals starting
at either the first value of each accumulations or 0 respectively.
- Total: Returns the total accumulation at all positions of the field.
There's currently plenty of duplicate work happening when multiple outputs
are used that could be optimized by a future refactor to field inputs.
Differential Revision: https://developer.blender.org/D12743
December 29, 2021, 16:23 (GMT)
Fix: Issues with attribute comparison in geometry nodes tests
A few typos in 17770192fb0c5fddda
lead to an incorrect count of custom
data layers in the test meshes. We only want to consider layers that are
not anonymous, and there was a copy and paste mistake.
December 29, 2021, 16:16 (GMT)
Nodes: Composite: UI fixes to time node
- Use default size consistent with other curve nodes
- Use column instead of row for properties
December 29, 2021, 15:36 (GMT)
: Local view + Geometry Nodes is broken for instances
`GeometrySet::compute_boundbox_without_instances` may not initialize min
max in some cases such as meshes without vertices.
This can result in a Bounding Box with impossible dimensions
So repeat the same solution seen in `BKE_object_boundbox_calc_from_mesh`
and set boundbox values to zero.
Reviewed By: HooglyBoogly
Differential Revision: https://developer.blender.org/D13664
December 29, 2021, 15:31 (GMT)
Cleanup: Remove dead code
December 29, 2021, 15:00 (GMT)
Nodes: Cleanup: Remove no op registration functions
All these function paramaters are set to NULL so they arent necessary.
Reviewed By: HooglyBoogly, JacquesLucke
Differential Revision: https://developer.blender.org/D13686
December 29, 2021, 14:46 (GMT)
gpu.types.GPUOffScreen: accept format argument for color texture
Some projects need more than 8-bit RGBA off-screen, so add the ability to
accept color format and defaults to RGBA8 so existing code should not be
Currently supported formats:
- RGBA8 (default)
Reviewed By: mano-wii
Differential Revision: https://developer.blender.org/D13650
December 29, 2021, 14:00 (GMT)
Fix: VSE colormix blend factor not working
Blend factor was used to adjust alpha of background image, which is not
correct. This was done in fdee84fd567a
where another change was, that
background alpha is copied into result, which is correct.
Apply blend factor to foreground image alpha channel.
December 29, 2021, 09:16 (GMT)
: Shading/Normals break on array modifier caps
The array modifier does not necessarily tag normals dirty.
If it doesnt, normals are recalculated "internally" using the offset ob
transform. This was happening for the array items, but not for the caps.
Now do the same thing for caps.
Maniphest Tasks: T94422
Differential Revision: https://developer.blender.org/D13681
December 29, 2021, 06:16 (GMT)
: Weld modifier crash after recent cleanup
I had assumed that the span's size was the same as the length variable.
In the future, separate lengths could be removed in favor of using
lengths directly from spans.
December 29, 2021, 03:51 (GMT)
December 29, 2021, 02:53 (GMT)
Fixes two instances of `-Wunused-but-set-variable`
There are several more of these but these were low hanging
and noisy with one being in a header functions.
December 29, 2021, 01:58 (GMT)
December 29, 2021, 00:25 (GMT)
Cleanup: Remove unused node tree "local sync" functions
December 28, 2021, 23:42 (GMT)
Cleanup: Use indices instead of pointers
This improves code readability.
Take the opportunity and improve the comments too.
December 28, 2021, 21:36 (GMT)
Cleanup: Return early, organize variable declarations
December 28, 2021, 20:49 (GMT)
Nodes: Enable unity build for function nodes
Unity build saves 5 seconds off the total build time when compiling `bf_nodes_function`.
Total build times went from 25s to 20s (20% reduction),
tested with ninja on linux running i5 8250U.
December 28, 2021, 20:18 (GMT)