Blender Git Commits

Use std::string_view for string splitting.

While being slightly more error prone, this change
gives a speedup of 1.9 s vs 1.2 s on a 23.3 MB 8-level
subdivided cube OBJ file. [1] The biggest time sink earlier
was splitting strings into smaller ones. Now it is `std::stof`
about which nothing much can be done.

`StringRef` has been completely removed to avoid
casts between `std::string_view::size_type` & `int64_t`
that `StringRef::size()` gives. Also, `find_{first/last}_{not/}_of`
and `substr` have been used a lot, which are missing in `StrinRef`.

The change also removes `rn` carriage return line breaks
while cleaning up the string.

Use `blender::StringRefNull` where null-terminated strings
are present.

`fprintf` has been replaced with `std::cerr` since
`std::string_view::data()` may give a pointer to a non
null terminated buffer. Also, error logging is not performance
-critical. [2]

[1] See week 7 reports for breakdown on the older timings.
https://wiki.blender.org/wiki/User:Ankitm/GSoC_2020_Daily_Reports#Week_7
[2] https://en.cppreference.com/w/cpp/string/basic_string_view/data

Remove deleted header from CMakeLists.txt

Use pragma once

Merge branch 'master' into soc-2020-io-performance

Fix crash due to OBJ files with no `o name` line

In some exporters, the group serves as the object name.

Also add some asserts.

Rename `list_of_objects` to `all_geometries`.

Merge branch 'master' into soc-2020-io-performance

Cleanup: Renaming, comments.

Don't add null Image* to the p-BSDF node.

Clean-up: Warnings, renaming variables.

Avoid .data() while creating a std::string from StringRef.

Remove OBJ prefix from containers.

That is indicated by the namespace itself..

Cleanup: Remove Raw* terminology, use geom_type.

After discussion with the mentors [1], the terminology to use
Raw has been removed & `Geometry` is the new name for
"raw objects". eGeometryType has also been added to remove
confusion with OB_MESH etc.

`std::unique_ptr<T > *a` has been replaced with `T *a`.

Naming changes:

`curr_ob` -> `current_geometry` in the parser &
`geometry` in the `Mesh` & `Curve` creators.

`mesh_from_raw_` -> `blender_mesh_`. Similar for curve.

[1]: https://docs.google.com/document/d/17Uzl47OljjoKgaMbukiLHUVGQP220lPTmPS-atb65mw/

Replace std::string_view with StringRef.

Add comments.

Merge branch 'master' into soc-2020-io-performance

Replace enum and its functions with Map for maps

The enum approach was adding lots of repetitive functions
and switch-case blocks. Use `blender::Map` instead.

Also fix nodes overlapping.

Connect Texture nodes with correct sockets of p-BSDF.

Add created material to the object.

Create image for image texture node.

Also keep pointer to MTLMaterial in the class itself.

Cleanup: clang-tidy warnings

else after return.

"..." can be made a static function instead of member function.

Fix bsdf_ being null; asserts for SOCK_RGBA

Use `ntreeType_Shader->idname` instead of manually entering the
ID to avoid mistakes (which I did!
`ShaderNodeTree` vs `ShaderNodetree`).

Add assert in case caller doesn't own the `nodetree_`.

Fix passing `float a, int b` to `Span` instead
of `float *, size_t size`.

Use Map's lookup instead of direct pointer to MTLMaterial

A direct pointer to a struct no longer points to the internal struct
of the `Map`, it seems. So use lookup which returns the reference too.