Blender Git Commits

Knife: New depth check toggle

Pressing 'V' will toggle depth testing on and off for the knife tool cut lines.
When a cut involves a lot of cut segments on an object it can be very helpful to hide cut segments which should be blocked from view by the object that is being cut.

Knife: Remove entire drag cut on undo

Previously when a knife cut was created by holding left click and dragging, undo would only undo each segment of the dragged cut individually.
This change makes it so the entire dragged cut is removed when undone.
Some refactors to the undo code were required to implement this.

Knife: Fixed distance and angle measurements not working with undo

Moved data required for distance and angle measurements into new struct KnifeMeasureData.
Now this struct is saved on the undo stack which fixes distance and angle measurements when undo is used.

Merge branch 'master' into soc-2021-knife-tools

Knife: Fixed undo not working with cut through

The number of new cuts recorded each undo frame was set based on linehits.
This broke when cut through was enabled.
Solution was to increment the new cuts count every time #knife_add_single_cut is ran.

Knife: Fixed undo deleting last vertex every time

Undo was deleting the first vertex of the last cut segment every time.
Now it only deletes it if the vertex has no other edges touching it.

Merge branch 'master' into soc-2021-knife-tools

Knife: Added undo functionality

Pressing ctrl-z will now undo the most recent cut segment made.
When drag cutting undo reverts each segment of the cut individually.
Currently this breaks visible distance and angle measurements after using undo but a fix will be committed soon.

Knife: Moved constrained angle mode to 'A' and moved cut through to 'C'

This change keeps the knife tool default modal key mappings more centered towards the left side of the keyboard, improving the workflow of the tool.

Knife: Removed 'E' knife cancel functionality and moved 'M' modal to 'D'

It is dangerous to have 'E' be able to cancel a user's entire cut as it is a key many could accidentally hit and there is no way to retrieve a lost cut. Removing it leaves 'Esc' as the key for cancelling a cut.

On many keyboards 'M' is far away from the other modal keys for the knife tool. 'D' allows for a better workflow by being closer.

Knife: Added local constrained angle mode

When using constrained angle mode, pressing C once will bring you to the current screen-space mode and pressing it again will now enter a new "local" mode.

This mode will snap along the plane of the current cut segment's face.
In the case where the cut was started on a edge or vertex it will snap along the plane of the current face the mouse is over, if this face is adjacent to that edge or vertex.

It made sense to implement a mode that works in this way after adding visible distance and angle measurements as now a user can snap the visible angle for the current cut.

Knife: Swapped right click and E functionality

Now right clicking creates a new cut and E cancels the entire cut.
Esc still works as normal for cancelling the cut.

Knife: Header/footer displays constrained angle and increment

This patch displays the current angle, relative to the positive X axis, in the header/footer when the knife tool is in constrained angle mode.
It also updates constrained angle mode to snap relative to the positive X axis in screen space (previously positive Y).

Knife: Change visible angle text precision

Now displays 3 digits instead of 2. This means one decimal place is almost always displayed,
except in the case where the cut was started on an edge.

Cleanup: Update comments to follow coding style

https://wiki.blender.org/wiki/Style_Guide/C_Cpp#Comments

Merge branch 'master' into soc-2021-knife-tools

Knife: Added visible distance and angle measurements

Pressing M while using the knife tool will now cycle through showing various measurements related to the current cut.

The different modes are:
Just Distance - Shows the length of the current cut segment
Just Angles - If the cut segment is touching any edges the corresponding angle is displayed
Both - Shows both distance and angles

Cleanup: Moved knife data init code into correct function

Knife: Updated header/footer for constrained axis

Now the header/footer shows X,Y,Z when constrained globally in the respective axis and x,y,z when constrained locally.

Knife: Snapping increment changes are shown immediately

Currently, when a user uses the number keys to input a new snapping angle increment in constrained angle mode it does not visually update until the mouse is jiggled.
This patch solves this problem so it now updates as each number is typed.