### Blender Git Statistics -> Developers -> ErikEnglesson

## Erik Englesson (ErikEnglesson)

Total Commits : **32**

Master Commits : **0**

Branch Commits : **32**

First Commit : **June 1, 2018**

Latest Commit : **August 12, 2018**

### Commits by Month

Date | Number of Commits | |
---|---|---|

August, 2018 | 7 | |

July, 2018 | 11 | |

June, 2018 | 14 |

### Commit Distribution

Path | Number of Commits |
---|---|

gsoc-2018-many-light-sampling | 32 |

### Favourite Files

Filename | Total Edits |
---|---|

kernel_light.h | 19 |

light.cpp | 15 |

light_tree.cpp | 15 |

kernel_path_surface.h | 11 |

light_tree.h | 10 |

kernel_types.h | 7 |

kernel_emission.h | 6 |

blender_sync.cpp | 4 |

scene.h | 4 |

kernel_path_volume.h | 4 |

### File Changes

Action | Total | Per Commit |
---|---|---|

Added | 2 | 0.1 |

Modified | 146 | 4.6 |

### Code Changes

Action | Total | Per Commit |
---|---|---|

Lines Added | 3 487 | 129.1 |

Lines Removed | 1 431 | 53.0 |

## Latest commits

August 12, 2018, 10:30 (GMT) |

Merge branch 'master' into gsoc-2018-many-light-sampling |

August 12, 2018, 09:59 (GMT) |

Cycles: light_tree_pdf() now accounts for splitting For the MIS calculations we need to be able to calculate the probability to sample a light using the light tree. This did not account for splitting so if splitting was used the probability would be wrong. This has now been fixed. Also, if we are in PATH mode then the splitting threshold is set to zero. |

August 12, 2018, 09:57 (GMT) |

Cycles: Removed unused code The simplified GGX code is no longer needed with the new splitting heuristic and has now been removed. |

August 10, 2018, 15:34 (GMT) |

Cycles: Removed energy term in SAOH denominator This should not affect the result since it is just a scale factor to all terms in the minimization. This term was not in eq. 2 of the paper. |

August 10, 2018, 15:31 (GMT) |

Cycles: Added more comments and renamed variables More code comments have been added to all code related to the light tree. I also renamed all uses of "light BVH" to use light tree instead to keep everything consistent. Functions and variable names that used the camel case naming convention has been changed to follow Blender's code style. Also, unneeded includes were removed. |

August 3, 2018, 15:22 (GMT) |

Cycles: Light tree: energy and light picking fixes When calculating the energy for a light source I previously returned zero energy if is_constant_emission() returned false. This has now been changed so it uses an emission of (1,1,1) instead. The normal that is used for light picking for the BSDF approximation in the importance calculations now takes into consideration if the point is on glass, a reflective or transmissive surface. The position and normal used for light picking is now stored in the ShaderData struct. |

August 3, 2018, 15:21 (GMT) |

Cycles: Light tree instancing and energy fixes Instancing for mesh lights now works with the light tree. The conversion from emission to luminance is now using linear_rgb_to_gray() instead. |

July 27, 2018, 16:19 (GMT) |

Cycles: WIP: Volumes are not using the light tree. If a shading point is inside or on the boundary of a volume then it will use the old sampling method until we have properly implemented the volume parts of the paper. Also, the PDF picking probability for volumes have now been updated properly since the PDF restructure. Tried to provide the correct shading point and normal to the MIS calculations. This part needs more work. |

July 27, 2018, 16:18 (GMT) |

Cycles: Light tree optimization The importance metric calculations now uses the fast_cos() and fast_acos() functions. This gave a 1.4x speedup on one of the test scenes. |

July 27, 2018, 16:16 (GMT) |

Cycles: Light tree related bug fixes - Fixed bug in triangle_light_pdf_area() from PDF refactor - Early exit if picking prob is zero in tree traversal - The background index is now an index into the lights array instead of the distribution array. |

MiikaHweb - Blender Git Statistics v1.06