Blender Git Statistics -> Developers -> ISS

Richard Antalik (ISS)

Total Commits : 300
Master Commits : 249
Branch Commits : 51
First Commit : December 22, 2018
Latest Commit : April 19, 2021 (Today)

Commits by Month

DateNumber of Commits
April, 20216
March, 202150
February, 202117
January, 202118
December, 202017
November, 202029
October, 202011
September, 20201
August, 20209
July, 202014
June, 202010
May, 202023
April, 202019
March, 20205
February, 20207
January, 20205
December, 20190
November, 20192
October, 20195
September, 201910
August, 20192
July, 20192
June, 20196
May, 201913
April, 20191
March, 20196
February, 20196
January, 20195
December, 20181

Commit Distribution

PathNumber of Commits
master249
temp-vse-h264-proxy12
ui-asset-view-template7
asset-browser-poselib7
tmp-2.83-cycles-rtx3-kernels5
blender-v2.83-release5
temp-vse-proxies4
temp-lanpr-cleanup24
temp-lanpr-cleanup4
temp_bmesh_multires4
vr_scene_inspection3
temp-vse-multi-framerates3
temp-vse-fast-scrubbing2
temp-vse-build-test1
temp-npr-smooth-contour1
tmp-T806031
temp-vse-ffmpeg-threading1
temp-vse-fast-scrubbing21
temp-vse-video-performance-detection1
temp-vse-downscale-preview1

Favourite Files

FilenameTotal Edits
sequencer.c54
sequencer_draw.c50
sequencer_edit.c49
sequencer_add.c34
space_sequencer.py33
rna_sequencer.c31
render.c28
BKE_sequencer.h28
versioning_290.c25
proxy.c24

File Changes

ActionTotalPer Commit
Added550.2
Modified1 0933.6
Deleted80.0

Code Changes

ActionTotalPer Commit
Lines Added14 59157.9
Lines Removed9 12336.2

Latest commits Feed

Revision 9623e2e by Richard Antalik (temp-vse-video-performance-detection)
8 hours 23 min ago
VSE: Build proxies only for slow movies

Don't build proxy file if movie is already fast enough to seek.
To determine movie performance, check if whole GOP can be decoded
in 50 milliseconds.

This test will ensure consistent performance on wide array of machines.

Downside is at most 50ms delay (per strip) when movie is added.
Ideally another test would be performed to detect whether next GOPs
do have same size or not as it may not be safe to assume that movies
will have consistent gop sizes. Even better would be to find biggest
one within small-ish range from start, and perform this test on it.
such test may add about 10ms of additional delay, but provide even more
consistency.
Revision b9207fb by Richard Antalik (master)
April 14, 2021, 12:25 (GMT)
FFmpeg: Adjust default proxy settings

GOP size and quality are adjusted for h264 codec.

These new values are based on result of benchmark on 9 random files:
https://docs.google.com/spreadsheets/d/1nOyUGjoVWUyhQ2y2lAd8VtFfyaY1wQNGj1krCCNbk7Y/edit?usp=sharing

Reducing quality to 50 reduces proxy filesize by about 2x on average
and has no significant impact on decoding performance.

Increasing GOP size from 2 to 10 also reduces proxy filesize 2x-3x
while scrubbing is only about 8% slower. It is still around 100FPS
with 1920x1080 media.
This is unfortunately about 50% slower than MJPEG, but this can be
improved with `fastdecode` tune applied to libx264 encoder

Quite surprisingly h264 codec presets had little influence on proxy
building performance as well as proxy filesize. So far it looks that
FFmpeg does initialize encoder in different way then Blender.
This applies mot only for presets but for tune and profile libx264
setting.
Once this issue is resolved, performance of proxies may be optimized
further.

Reviewed By: sergey

Differential Revision: https://developer.blender.org/D10897
Revision 8777a44 by Richard Antalik (master)
April 8, 2021, 16:51 (GMT)
VSE: Fix crash when building proxy

When video file for strip doesn't exist, building crashes on NULL
dereference.

This check was removed by 04e1feb83051.
Revision a19aa09 by Richard Antalik (master)
April 8, 2021, 16:44 (GMT)
VSE: Fix building image proxies

Broken by 04e1feb83051

Caused by accidentaly moving `SEQ_proxy_rebuild_finish` outside of
`if (nseq->type == SEQ_TYPE_MOVIE)` condition in function
`SEQ_proxy_rebuild_context()`.
Revision 7faf5b0 by Richard Antalik (master)
April 1, 2021, 09:30 (GMT)
Fix condition for ffmpeg seek workaround

This condition was in contradiction with comment for function
`ffmpeg_generic_seek_workaround()`.

I have noticed, that formats that seeked well used this workaround.
Problem was that I misunderstood code from `av_seek_frame()` - formats
with `read_seek()` function stil don't use generic seeking method.
This is defined in `seek_frame_internal()`
Revision 6fe2d6b by Richard Antalik (master)
April 1, 2021, 08:45 (GMT)
Fix freezed proxy frames

`ffmpeg_generic_seek_workaround()` applied negative offset for seqrched
packet timestamp, but proxies always start from 0 and timestamp can be
negative.

Limit timestamp value to 0, because `av_seek_frame()` doesn't accept
negative timestamps and returns with error. This prevents seeking from
working correctly.
Revision 4d856ec by Richard Antalik (master)
March 31, 2021, 10:34 (GMT)
Cleanup: Fix warnings

Introduced in b128ffd53970
Revision c3d8d54 by Richard Antalik (temp-vse-build-test)
March 31, 2021, 10:15 (GMT)
Cleanup: Fix warnings

Introduced in b128ffd53970
Revision 645fc0c by Richard Antalik (master)
March 31, 2021, 07:46 (GMT)
Fix build error on windows

Error was caused by using `#if` directive in `PyDoc_STRVAR` macro.

This partially reverts 1e4c35d910e18858c41924f9e27ef8e1070cbd0a
Revision b128ffd by Richard Antalik (master)
March 31, 2021, 07:27 (GMT)
Cleanup: Remove SEQ_CURRENT_BEGIN macro

Use LISTBASE_FOREACH instead.
SEQ_CURRENT_BEGIN did null checks, so now these must be explicit.

Reviewed By: campbellbarton

Differential Revision: https://developer.blender.org/D10823

MiikaHweb - Blender Git Statistics v1.06
By: Miika HämäläinenLast update: Nov-07-2014 14:18 MiikaHweb | 2003-2021