Blender Git Statistics -> Developers -> hzuika

Yuki Hashimoto (hzuika)

Total Commits : 8
Master Commits : 8
Branch Commits : 0
First Commit : July 5, 2021
Latest Commit : July 21, 2021

Commits by Month

DateNumber of Commits
July, 20218

Favourite Files

FilenameTotal Edits
GHOST_WindowViewCocoa.h4
GHOST_WindowCocoa.h3
interface_widgets.c2
wm_window.c1
blender_release.cmake1
CMakeLists.txt1
CMakeLists.txt1
wm.c1
GHOST_C-api.h1
GHOST_IWindow.h1

File Changes

ActionTotalPer Commit
Modified232.9

Code Changes

ActionTotalPer Commit
Lines Added44255.3
Lines Removed556.9

Latest commits Feed

Revision 22bef35 by Yuki Hashimoto / Campbell Barton (master)
July 21, 2021, 13:14 (GMT)
Cleanup: correct the comment in ghost

The same comments were written in clientToScreen and screenToClient in
GHOST. I corrected them.

Ref D11986
Revision 0ef794b by Yuki Hashimoto / Brecht Van Lommel (master)
July 5, 2021, 15:24 (GMT)
macOS: support Chinese and Korean input for text buttons

This patch extends D11695 to provide full support for Chinese and Korean
input on macOS.

Chinese input notes:

You can input symbolic characters (such as '! , '$') during Chinese input.

The difference from Japanese input is that multiple `insertText` may be
called with a single key down (`keyDown` method). This happens when you input
a symbolic character (such as '! , '$') during conversion.

The conversion is confirmed (`insertText`) and the symbolic character is
entered (`insertText`). To solve this problem, I have `result_text` to
concatenate the strings and store them in `result`.

Korean input notes:

Korean does not display a conversion suggestion window.

Like Chinese, Korean input may call multiple `insertText` methods. Also,
in Korean, the previous confirmation (`setMarkedText` and `insertText`) and
the next conversion is processed (`setMarkedText`) may be called
simultaneously with a single key down (`keyDown` method).

For example:
1. press g ? (`setMarkedText`)
2. press k ? (`setMarkedText`)
3. press t ? (`setMarkedText`)
4. press k ?? (`setMarkedText`, `insertText`, `setMarkedText`)

Fixed so that the `insertText` and the last `setMarkedText` are processed.

Also, if a control character (such as Arrow, Enter) is input during Korean
input, the conversion will be confirmed (`setMarkedText`, `insertText`) and
the original control character will be processed.

In other words, if you press the left arrow key while typing in Korean, the
cursor will move to the left after the character is confirmed. Therefore, I
modified the `keyDown` method so that the `handleKeyEvent` is called again
after the `insertText` is processed in the `interpretKeyEvents` method.

Differential Revision: https://developer.blender.org/D11699
Revision 83e2f8c by Yuki Hashimoto / Brecht Van Lommel (master)
July 5, 2021, 15:24 (GMT)
macOS: support Japanese input for text buttons

Blender did not support to input East Asian characters (Chinese, Japanese,
Korean) on macOS. This patch adds support for Japanese input, by implementing
the appropriate processing for the NSTextInputClient protocol.

Technical notes:
* The conversion candidate window is drawn by the input method program calling
`firstRectForCharacterRange`.
* The string before confirmation (called `composite` in blender) is handled in
the `setMarkedText` method called by the input method program.
* The string after confirmation (called `result` in the blender) is processed
in the `insertText` method called by the input method program.

Ref T51283

Differential Revision: https://developer.blender.org/D11695
Revision ac1ed19 by Yuki Hashimoto / Brecht Van Lommel (master)
July 5, 2021, 15:20 (GMT)
Fix: macOS wrong IME candidate window position on first display

IME conversion candidate window was displayed at the mouse position, instead of
below the cursor or text selection.

Blender need to tell the input method program where the conversion candidate
window is during Japanese and Chinese input.

In macOS, the `firstRectforCharacterRange` is called when input by the input
method starts, and the position of the conversion candidate window is
specified. Therefore, it is necessary to set the position of the conversion
candidate window before input starts. This patch changes it so that the position
of the conversion candidate window is always set when the cursor is drawn.

Differential Revision: https://developer.blender.org/D11697
Revision 32124b9 by Yuki Hashimoto / Brecht Van Lommel (master)
July 5, 2021, 12:32 (GMT)
Fix: IME input displays text after cursor before cursor

When inserting text using IME on a button, the character after the cursor is
displayed before the cursor.

This bug seems to have occurred during the refactoring in D765.

Differential Revision: https://developer.blender.org/D11072
Revision 2d0b9fa by Yuki Hashimoto / Brecht Van Lommel (master)
July 5, 2021, 12:32 (GMT)
Fix: IME conversion candidate window not correctly placed on macOS

Blender needs to tell the input method program where the conversion
candidate window is during Japanese and Chinese input.

In macOS, there are displays where the window size and the native pixel size
are different, so the candidate window may appear in an unnatural position.

This patch converts the cursor position x and y for matching macOS window
coordinate. On Windows, GHOST_GetNativePixelSize returns 1, so it has no effect.

Differential Revision: https://developer.blender.org/D11696
Revision c1ba68d by Yuki Hashimoto / Brecht Van Lommel (master)
July 5, 2021, 11:10 (GMT)
Cleanup: use arrayWithObject to reduce the code

Similar code is found in Apple's code samples.

Differential Revision: https://developer.blender.org/D11434
Revision 2c6c1b6 by Yuki Hashimoto / Brecht Van Lommel (master)
July 5, 2021, 11:10 (GMT)
Cleanup: replace NSTextInput with NSTextInputClient

This revision replaces the deprecated protocol NSTextInput with
NSTextInputClient in Cocoa Text View. No functional changes.

For more information of the methods, please see:
https://developer.apple.com/documentation/appkit/nstextinputclient

Differential Revision: https://developer.blender.org/D11407

MiikaHweb - Blender Git Statistics v1.06
By: Miika HämäläinenLast update: Nov-07-2014 14:18 MiikaHweb | 2003-2021