http://www.miikahweb.com/feed.php MiikaHweb - Blender Commits By Jbakker http://www.miikahweb.com/ MiikaHweb - Blender Commits By Jbakker fi Wed, 01 Apr 20 08:09:08 +0000 MiikaHweb RSS contact at miikahweb.com <![CDATA[[b0bd9b4] master: Fix T75244: Screw Modifier Crash]]> http://www.miikahweb.com/en/blender/git-logs/commit/b0bd9b4c70ccdf5d6c2891a543fafd36be0d8af0 b0bd9b4
Branches : master
Author : Jeroen Bakker (jbakker)
----------------------------------------
Fix T75244: Screw Modifier Crash

Draw batch extraction wrongly assumed that when mapped extraction
happened that all original data could be found. This is not the case as
mapped extraction is also enabled when part of the data is present.

This fix does additional nullptr checks.

----------------------------------------
1 Path Changed]]>
Tue, 31 Mar 2020 14:05:19 +0000 http://www.miikahweb.com/en/blender/git-logs/commit/b0bd9b4c70ccdf5d6c2891a543fafd36be0d8af0Jeroen Bakker
<![CDATA[[155f917] master: Fix T73513: Facing Overlay Intervene With Selection]]> http://www.miikahweb.com/en/blender/git-logs/commit/155f917403b32725a9f9c04ec098964fcbcf0204 155f917
Branches : master
Author : Jeroen Bakker (jbakker)
----------------------------------------
Fix T73513: Facing Overlay Intervene With Selection

Do not draw the facing overlay during selection.

----------------------------------------
1 Path Changed]]>
Tue, 31 Mar 2020 09:47:09 +0000 http://www.miikahweb.com/en/blender/git-logs/commit/155f917403b32725a9f9c04ec098964fcbcf0204Jeroen Bakker
<![CDATA[[039d619] master: Fix T74898: Multiresolution Ghost After Orbiting]]> http://www.miikahweb.com/en/blender/git-logs/commit/039d619c760e1dccdc2d1674c30a300a3a21e312 039d619
Branches : master
Author : Jeroen Bakker (jbakker)
----------------------------------------
Fix T74898: Multiresolution Ghost After Orbiting

EEVEE and Workbench both had the same issue that they continue with the
last sample when leaving navigating. This is ok for regular meshes as
they are all the same. For multiresolution it ain't as a low res version
of the mesh is used during navigation.

This patch also resets the AA samples when the user leaves navigation.

----------------------------------------
7 Paths Changed]]>
Tue, 31 Mar 2020 08:29:34 +0000 http://www.miikahweb.com/en/blender/git-logs/commit/039d619c760e1dccdc2d1674c30a300a3a21e312Jeroen Bakker
<![CDATA[[a2d19c1] master: NormalOverlay: Center Dot Normal Drawing With Modifiers]]> http://www.miikahweb.com/en/blender/git-logs/commit/a2d19c1f781157eadc57db27ac59338bc9fa22c8 a2d19c1
Branches : master
Author : Jeroen Bakker (jbakker)
----------------------------------------
NormalOverlay: Center Dot Normal Drawing With Modifiers

When using generative modifiers too many center dots were rendered in
the normal overlay. This patch only renders the normals of original
center dots.

Known issue: decoding the `norAndFlag` has issues on Intel GPU.

----------------------------------------
2 Paths Changed]]>
Mon, 30 Mar 2020 12:39:16 +0000 http://www.miikahweb.com/en/blender/git-logs/commit/a2d19c1f781157eadc57db27ac59338bc9fa22c8Jeroen Bakker
<![CDATA[[57d8bde] master: Normal Overlay: Hide Normals Of Generated Loops]]> http://www.miikahweb.com/en/blender/git-logs/commit/57d8bde0886ff7573e69c1fbe4d857cb3373e7a7 57d8bde
Branches : master
Author : Jeroen Bakker (jbakker)
----------------------------------------
Normal Overlay: Hide Normals Of Generated Loops

The loop normals were always drawn. We used to only draw the normals if
it was mapped to an original loop of the mesh. Due to recent changes we
can not find the correct loop and decide if we need to draw them.

Note still need to check the face dots normals. This is more complicated
as facedot normals needs to be encoded in a different way

----------------------------------------
1 Path Changed]]>
Mon, 30 Mar 2020 12:06:54 +0000 http://www.miikahweb.com/en/blender/git-logs/commit/57d8bde0886ff7573e69c1fbe4d857cb3373e7a7Jeroen Bakker
<![CDATA[[cf258b0] master: Fix T75053: Paint Overlay Show Modified Wires and Edges]]> http://www.miikahweb.com/en/blender/git-logs/commit/cf258b02f4494089d512ecc5185bba9cc9db576e cf258b0
Branches : master
Author : Jeroen Bakker (jbakker)
----------------------------------------
Fix T75053: Paint Overlay Show Modified Wires and Edges

The paint mask overlay showed the wires and edges of the final mesh.
This change will only draw wires and edges that are mapped to the
original mesh.

This change enables mapping data in regular Mesh extraction. This
can also be used for better drawing of the normal overlay.

Reviewed By: Clément Foucault

Differential Revision: https://developer.blender.org/D7277

----------------------------------------
1 Path Changed]]>
Mon, 30 Mar 2020 11:13:42 +0000 http://www.miikahweb.com/en/blender/git-logs/commit/cf258b02f4494089d512ecc5185bba9cc9db576eJeroen Bakker
<![CDATA[[7ed3ebb] master: Fix T67888: Incorrect Wireframe After Applying SubSurf/MultiRes...]]> http://www.miikahweb.com/en/blender/git-logs/commit/7ed3ebbc6e1f95203c050e683a140b7ac1e7b705 7ed3ebb
Branches : master
Author : Jeroen Bakker (jbakker)
----------------------------------------
Fix T67888: Incorrect Wireframe After Applying SubSurf/MultiRes

Show control edges stores the control edges in the mesh which is
picked up by the draw manager. When applyng a subsurf (or multires) we
don't want that data present in the base mesh. Any rebuilding of the mesh
would overwrite the data anyway.

This patch introduces a new flag for applying modifiers
that can be checked to ignore storing display specific data in
the base mesh.

Reviewed By: Brecht van Lommel

Differential Revision: https://developer.blender.org/D7163

----------------------------------------
6 Paths Changed]]>
Thu, 26 Mar 2020 14:34:53 +0000 http://www.miikahweb.com/en/blender/git-logs/commit/7ed3ebbc6e1f95203c050e683a140b7ac1e7b705Jeroen Bakker
<![CDATA[[2e8fb95] master: SubDiv: Incorrect normals loose edges]]> http://www.miikahweb.com/en/blender/git-logs/commit/2e8fb95e7c69274944ecb44b2b51f8b4307f88ae 2e8fb95
Branches : master
Author : Jeroen Bakker (jbakker)
----------------------------------------
SubDiv: Incorrect normals loose edges

The normals of loose edges can be non uniform as they aren't normalized.
Checked with what happens with edit loose edges and synchronized the
implementation.

Reviewed By: Brecht van Lommel

Differential Revision: https://developer.blender.org/D7127

----------------------------------------
1 Path Changed]]>
Thu, 26 Mar 2020 13:35:27 +0000 http://www.miikahweb.com/en/blender/git-logs/commit/2e8fb95e7c69274944ecb44b2b51f8b4307f88aeJeroen Bakker
<![CDATA[[0545a84] master: Fix Crash In Paint Overlay]]> http://www.miikahweb.com/en/blender/git-logs/commit/0545a8472946ecc7391f8554c4a214b45952d19e 0545a84
Branches : master
Author : Jeroen Bakker (jbakker)
----------------------------------------
Fix Crash In Paint Overlay

The previous implementation tested the normal behavior and ignored some
edge cases. This patch will also test for NULL in all cases

----------------------------------------
1 Path Changed]]>
Thu, 26 Mar 2020 13:16:17 +0000 http://www.miikahweb.com/en/blender/git-logs/commit/0545a8472946ecc7391f8554c4a214b45952d19eJeroen Bakker
<![CDATA[[1ca1744] master: Fix T70807: Weight Paint Overlay XRay]]> http://www.miikahweb.com/en/blender/git-logs/commit/1ca1744c29e299f36a83506aec23d9bc99b6e48c 1ca1744
Branches : master
Author : Jeroen Bakker (jbakker)
----------------------------------------
Fix T70807: Weight Paint Overlay XRay

Weight paint overlay was not working when XRay was turned on.

The Weight Paint overlay is rendered directly into the default
framebuffer with a depth equal test. This test fails as the depth won't match.
This patch will update the depth buffer in these cases.

Reviewed By: fclem

Differential Revision: https://developer.blender.org/D7176

----------------------------------------
2 Paths Changed]]>
Thu, 26 Mar 2020 12:35:06 +0000 http://www.miikahweb.com/en/blender/git-logs/commit/1ca1744c29e299f36a83506aec23d9bc99b6e48cJeroen Bakker
<![CDATA[[b2f04fc] master: Fix T75062: Frame Flashes During 3D Viewport Animation Playback...]]> http://www.miikahweb.com/en/blender/git-logs/commit/b2f04fce2d21c631c5a0d4e5015c8b7b0c0c8d0d b2f04fc
Branches : master
Author : Jeroen Bakker (jbakker)
----------------------------------------
Fix T75062: Frame Flashes During 3D Viewport Animation Playback

This issue became visible after fixing other TAA issues recently.
The sample count of the first frame wasn't reset resulting that the
incorrect resolve took place. This issue was already there beforehand,
it is just much clearer during the recent changes.

Now the `taa_sample will be reset when performing an animation playback
in the 3d viewport.

----------------------------------------
1 Path Changed]]>
Thu, 26 Mar 2020 07:22:52 +0000 http://www.miikahweb.com/en/blender/git-logs/commit/b2f04fce2d21c631c5a0d4e5015c8b7b0c0c8d0dJeroen Bakker
<![CDATA[[28c3d95] master: Fix T74782: WorkBench TAA Artifacts During Painting/Drawing]]> http://www.miikahweb.com/en/blender/git-logs/commit/28c3d952dbde6f1e911360f716cb1cdb65863b5e 28c3d95
Branches : master
Author : Jeroen Bakker (jbakker)
----------------------------------------
Fix T74782: WorkBench TAA Artifacts During Painting/Drawing

When the TAA is finished the screen can still be redrawn by other
operations without the TAA resets.
If that happened the TAA did add a blank sample to the result as the
scene wasn't drawn, but the was processed.

Reviewed By: Clément Foucault

Differential Revision: https://developer.blender.org/D7226

----------------------------------------
1 Path Changed]]>
Tue, 24 Mar 2020 15:04:09 +0000 http://www.miikahweb.com/en/blender/git-logs/commit/28c3d952dbde6f1e911360f716cb1cdb65863b5eJeroen Bakker
<![CDATA[[b759857] master: Revert "Fix T74782: WorkBench TAA Artifacts During Painting...]]> http://www.miikahweb.com/en/blender/git-logs/commit/b759857825b80af98621c2ff4b52f106ab79576c b759857
Branches : master
Author : Jeroen Bakker (jbakker)
----------------------------------------
Revert "Fix T74782: WorkBench TAA Artifacts During Painting/Drawing"

This reverts commit 58ac113b76d950c72c7319094f7e6cc61c70dc59.

----------------------------------------
1 Path Changed]]>
Tue, 24 Mar 2020 13:02:16 +0000 http://www.miikahweb.com/en/blender/git-logs/commit/b759857825b80af98621c2ff4b52f106ab79576cJeroen Bakker
<![CDATA[[58ac113] master: Fix T74782: WorkBench TAA Artifacts During Painting/Drawing]]> http://www.miikahweb.com/en/blender/git-logs/commit/58ac113b76d950c72c7319094f7e6cc61c70dc59 58ac113
Branches : master
Author : Jeroen Bakker (jbakker)
----------------------------------------
Fix T74782: WorkBench TAA Artifacts During Painting/Drawing

When the TAA is finished the screen can still be redrawn by other
operations without the TAA needs to be reset.
If that happened the TAA did add a blank sample to the result.

This patch will add an early exit in the case TAA was finished. Note
that there are still some cases still not working. The overlay engine
can in certain circumstances draw directly into the default_fb what can
lead to render artifacts.

----------------------------------------
1 Path Changed]]>
Mon, 23 Mar 2020 16:10:01 +0000 http://www.miikahweb.com/en/blender/git-logs/commit/58ac113b76d950c72c7319094f7e6cc61c70dc59Jeroen Bakker
<![CDATA[[0b116a8] master: Fix T74923: Weight Painting Overlay Invisible for In Front...]]> http://www.miikahweb.com/en/blender/git-logs/commit/0b116a84c9380166337722f5d5b3e255e19951b8 0b116a8
Branches : master
Author : Jeroen Bakker (jbakker)
----------------------------------------
Fix T74923: Weight Painting Overlay Invisible for In Front Objects

For In Front Objects we need to use the in front depth buffer.

This patch will use the in front depth buffer and also makes sure that
it is filled with the center pixel depth.

Reviewed By: fclem

Differential Revision: https://developer.blender.org/D7216

----------------------------------------
5 Paths Changed]]>
Mon, 23 Mar 2020 13:03:39 +0000 http://www.miikahweb.com/en/blender/git-logs/commit/0b116a84c9380166337722f5d5b3e255e19951b8Jeroen Bakker
<![CDATA[[6a5bd81] master: Fix T74586: Image Editor Uses Invalid Display Channels]]> http://www.miikahweb.com/en/blender/git-logs/commit/6a5bd812b569d5fe1f09bd5610ce9d0c119f1a21 6a5bd81
Branches : master
Author : Jeroen Bakker (jbakker)
----------------------------------------
Fix T74586: Image Editor Uses Invalid Display Channels

When using the image editor the display channels attribute can become
invalid when selecting another image/buffer. This patch will check what
display channels are valid and when an invalid channel is selected it
will fall back to the color channel.

To de-duplicate the code it also introduces a
`ED_space_image_get_display_channel_mask` function that will determine
the valid bitflags for the display channel of a given `ImBuf`.

----------------------------------------
4 Paths Changed]]>
Mon, 23 Mar 2020 12:56:42 +0000 http://www.miikahweb.com/en/blender/git-logs/commit/6a5bd812b569d5fe1f09bd5610ce9d0c119f1a21Jeroen Bakker
<![CDATA[[46c0da6] master: Fix T74964: Stereo Viewport Rendering Not Working]]> http://www.miikahweb.com/en/blender/git-logs/commit/46c0da6e69c38973e5616bb0a0f7f2ff7b43d5fa 46c0da6
Branches : master
Author : Jeroen Bakker (jbakker)
----------------------------------------
Fix T74964: Stereo Viewport Rendering Not Working

On some platforms the stereo viewport rendering was not working. The
issue was that the fragment shader and vertex shaded didn't match. Some
platforms will remove the non-matching in/out parameters and blender
needs to provide only the optimal set of parameters. Other platform
still want to receive data for the parameters that aren't used.

This fix uses the correct vertex shader that matches the fragment shader
making both platforms render the same result.

----------------------------------------
1 Path Changed]]>
Mon, 23 Mar 2020 08:10:37 +0000 http://www.miikahweb.com/en/blender/git-logs/commit/46c0da6e69c38973e5616bb0a0f7f2ff7b43d5faJeroen Bakker
<![CDATA[[8ba9efb] master: Fix T74811: GreasePencil Stereo Rendering]]> http://www.miikahweb.com/en/blender/git-logs/commit/8ba9efb7d8ff399aaf3c65fd14272d0bc6f2ab39 8ba9efb
Branches : master
Author : Jeroen Bakker (jbakker)
----------------------------------------
Fix T74811: GreasePencil Stereo Rendering

When using grease pencil in a stereo rendering the grease pencil objects are
only visible in the left eye. In the viewport it renders both.

Issue is related that `DRW_render_gpencil` only renders a single view. But
`DRW_render_to_image` renders all views. This patch puts this in a loop to
render both eyes.

Reviewed By: fclem

Differential Revision: https://developer.blender.org/D7154

----------------------------------------
2 Paths Changed]]>
Fri, 20 Mar 2020 06:47:04 +0000 http://www.miikahweb.com/en/blender/git-logs/commit/8ba9efb7d8ff399aaf3c65fd14272d0bc6f2ab39Jeroen Bakker
<![CDATA[[4fc45c7] master: Fix T74643: Outline Overlay Shows Hidden Faces]]> http://www.miikahweb.com/en/blender/git-logs/commit/4fc45c7a2b75df1a0e07150c101b664e189550b7 4fc45c7
Branches : master
Author : Jeroen Bakker (jbakker)
----------------------------------------
Fix T74643: Outline Overlay Shows Hidden Faces

When in editmode faces can be hidden, but in object mode these faces are
still visible. The flag if a face was hidden in edit mode is stored in
object mode, but should not be used.

The edge detection gpu batch did detect hidden faces and didn't add them
to the draw batch. The edge detection gpu batch is used for workbench
shadows, custom bone shapes and object outlines.

This patch adds all faces to the edge detection batch.

Reviewed By: fclem

Differential Revision: https://developer.blender.org/D7157

----------------------------------------
1 Path Changed]]>
Fri, 20 Mar 2020 06:43:31 +0000 http://www.miikahweb.com/en/blender/git-logs/commit/4fc45c7a2b75df1a0e07150c101b664e189550b7Jeroen Bakker
<![CDATA[[2982c9b] master: ColorManagement: Incorrect Memory Read for RGB images]]> http://www.miikahweb.com/en/blender/git-logs/commit/2982c9ba0a9c2152cb676bc4bb71a319f8f18ad8 2982c9b
Branches : master
Author : Jeroen Bakker (jbakker)
----------------------------------------
ColorManagement: Incorrect Memory Read for RGB images

When RGB images or BW images are converted to a GPU texture and color
space conversion was needed the images were read incorrectly.

This patch checks the correct amount of channels in the image and uses
that as the correct pixel stride.

----------------------------------------
1 Path Changed]]>
Thu, 19 Mar 2020 14:26:53 +0000 http://www.miikahweb.com/en/blender/git-logs/commit/2982c9ba0a9c2152cb676bc4bb71a319f8f18ad8Jeroen Bakker