http://www.miikahweb.com/feed.php MiikaHweb - Blender Temp-ui-button-type-refactor Branch http://www.miikahweb.com/ MiikaHweb - Blender Temp-ui-button-type-refactor Branch fi Tue, 19 Jan 21 23:25:25 +0000 MiikaHweb RSS contact at miikahweb.com <![CDATA[[0d2d4a6]: Merge branch 'master' into temp-ui-button-type-refactor]]> http://www.miikahweb.com/en/blender/git-logs/commit/0d2d4a6d4a75ac38c41f872c88255eab70e88ab7 0d2d4a6
Branches : temp-ui-button-type-refactor
Author : Julian Eisel (Severin)
----------------------------------------
Merge branch 'master' into temp-ui-button-type-refactor

----------------------------------------
0 Paths Changed]]>
Fri, 07 Aug 2020 11:04:31 +0000 http://www.miikahweb.com/en/blender/git-logs/commit/0d2d4a6d4a75ac38c41f872c88255eab70e88ab7Julian Eisel
<![CDATA[[89dbb12]: Add own button type for progress-bar, don't using uiBut.a1...]]> http://www.miikahweb.com/en/blender/git-logs/commit/89dbb12c29b62759d82b62d3e197598b6b973a04 89dbb12
Branches : temp-ui-button-type-refactor
Author : Julian Eisel (Severin)
----------------------------------------
Add own button type for progress-bar, don't using uiBut.a1 for progress

----------------------------------------
4 Paths Changed]]>
Fri, 03 Jul 2020 14:31:29 +0000 http://www.miikahweb.com/en/blender/git-logs/commit/89dbb12c29b62759d82b62d3e197598b6b973a04Julian Eisel
<![CDATA[[9b416c6]: Add own button type for color buttons, don't using uiBut.a1...]]> http://www.miikahweb.com/en/blender/git-logs/commit/9b416c66fb714bdfd15a481489dbf650d0f389ea 9b416c6
Branches : temp-ui-button-type-refactor
Author : Julian Eisel (Severin)
----------------------------------------
Add own button type for color buttons, don't using uiBut.a1/.a2 for them

----------------------------------------
7 Paths Changed]]>
Fri, 03 Jul 2020 16:47:35 +0000 http://www.miikahweb.com/en/blender/git-logs/commit/9b416c66fb714bdfd15a481489dbf650d0f389eaJulian Eisel
<![CDATA[[4de632b]: Merge branch 'master' into temp-ui-button-type-refactor]]> http://www.miikahweb.com/en/blender/git-logs/commit/4de632b48b3ca2bbfcd1a649c6512f7bdc741074 4de632b
Branches : temp-ui-button-type-refactor
Author : Julian Eisel (Severin)
----------------------------------------
Merge branch 'master' into temp-ui-button-type-refactor

----------------------------------------
0 Paths Changed]]>
Fri, 03 Jul 2020 13:41:04 +0000 http://www.miikahweb.com/en/blender/git-logs/commit/4de632b48b3ca2bbfcd1a649c6512f7bdc741074Julian Eisel
<![CDATA[[2400160]: Fix missing NULL checks for buttons without layout]]> http://www.miikahweb.com/en/blender/git-logs/commit/2400160bc42d58a7a757f42b6906c4a7add948d7 2400160
Branches : temp-ui-button-type-refactor
Author : Julian Eisel (Severin)
----------------------------------------
Fix missing NULL checks for buttons without layout

----------------------------------------
1 Path Changed]]>
Sun, 07 Jun 2020 21:45:37 +0000 http://www.miikahweb.com/en/blender/git-logs/commit/2400160bc42d58a7a757f42b6906c4a7add948d7Julian Eisel
<![CDATA[[2a515fe]: Store search item in search-button data, don't reuse general...]]> http://www.miikahweb.com/en/blender/git-logs/commit/2a515fe61244b3837fc77e5dfe9870ee6d934dfb 2a515fe
Branches : temp-ui-button-type-refactor
Author : Julian Eisel (Severin)
----------------------------------------
Store search item in search-button data, don't reuse general void pointer

Rather than re-using the `uiBut.func_arg2` pointer to reference the active
search item, have an own pointer for that in `uiButSearch`.

Unfortunately, we still need to pass the reference as `arg2` to the
`uiBut.func` callback. But we don't need to keep `uiBut.func_arg2` set the
entire time for that.

----------------------------------------
4 Paths Changed]]>
Sun, 07 Jun 2020 21:27:01 +0000 http://www.miikahweb.com/en/blender/git-logs/commit/2a515fe61244b3837fc77e5dfe9870ee6d934dfbJulian Eisel
<![CDATA[[a903f7c]: Merge branch 'master' into temp-ui-button-type-refactor]]> http://www.miikahweb.com/en/blender/git-logs/commit/a903f7c2439ad302b84ae8405dd47deed0e8f9e3 a903f7c
Branches : temp-ui-button-type-refactor
Author : Julian Eisel (Severin)
----------------------------------------
Merge branch 'master' into temp-ui-button-type-refactor

----------------------------------------
0 Paths Changed]]>
Sun, 07 Jun 2020 21:29:41 +0000 http://www.miikahweb.com/en/blender/git-logs/commit/a903f7c2439ad302b84ae8405dd47deed0e8f9e3Julian Eisel
<![CDATA[[190ef51]: Remove unnecessary `uiButSearchData` struct]]> http://www.miikahweb.com/en/blender/git-logs/commit/190ef51fd584e5c58f7ff1bba2dcb86db6da27be 190ef51
Branches : temp-ui-button-type-refactor
Author : Julian Eisel (Severin)
----------------------------------------
Remove unnecessary `uiButSearchData` struct

This doesn't add anything useful if we already have a struct for search
buttons. At the very least it should not be allocated.

Also uses clearer names for `uiButSearch` members.

----------------------------------------
6 Paths Changed]]>
Fri, 05 Jun 2020 12:18:46 +0000 http://www.miikahweb.com/en/blender/git-logs/commit/190ef51fd584e5c58f7ff1bba2dcb86db6da27beJulian Eisel
<![CDATA[[51afd98]: Fixes for changes in master]]> http://www.miikahweb.com/en/blender/git-logs/commit/51afd98b1dc2ec29ea1a0fad8cdbe4fb0834d215 51afd98
Branches : temp-ui-button-type-refactor
Author : Julian Eisel (Severin)
----------------------------------------
Fixes for changes in master

----------------------------------------
5 Paths Changed]]>
Fri, 05 Jun 2020 11:54:58 +0000 http://www.miikahweb.com/en/blender/git-logs/commit/51afd98b1dc2ec29ea1a0fad8cdbe4fb0834d215Julian Eisel
<![CDATA[[6609fa2]: Merge branch 'master' into temp-ui-cleanup]]> http://www.miikahweb.com/en/blender/git-logs/commit/6609fa29968454c35efec909955d9296d1962cc7 6609fa2
Branches : temp-ui-button-type-refactor
Author : Julian Eisel (Severin)
----------------------------------------
Merge branch 'master' into temp-ui-cleanup

----------------------------------------
0 Paths Changed]]>
Fri, 05 Jun 2020 11:54:45 +0000 http://www.miikahweb.com/en/blender/git-logs/commit/6609fa29968454c35efec909955d9296d1962cc7Julian Eisel
<![CDATA[[b4f92bf]: UI Code Quality: Use derived structs for search buttons and...]]> http://www.miikahweb.com/en/blender/git-logs/commit/b4f92bf7bc59aaacb0baefc8c0ad5c6914c23dad b4f92bf
Branches : temp-ui-button-type-refactor
Author : Julian Eisel (Severin)
----------------------------------------
UI Code Quality: Use derived structs for search buttons and decorators

The current on-size-fits-all `uiBut` creates quite a mess, where it's hard to
reason about which members are free for use, under which conditions they are
used and how. This tries to untangle that mess.
A draw-back is that many casts have to be done although this seems reasonable.

(I don't expect an in-depth review, but would like to have the general design
change reviewed first.)

A complication was that we sometimes change the button type after it's created.
So I had to add logic to reallocate the button for use with the new, possibly
derived struct. Ideally that wouldn't be needed, but for now that's what we have.
This is also something I'd like to have reviewed.

Differential Revision: https://developer.blender.org/D7610

----------------------------------------
8 Paths Changed]]>
Sun, 03 May 2020 20:59:17 +0000 http://www.miikahweb.com/en/blender/git-logs/commit/b4f92bf7bc59aaacb0baefc8c0ad5c6914c23dadJulian Eisel
<![CDATA[[dc9df65]: Add own derived struct for search buttons]]> http://www.miikahweb.com/en/blender/git-logs/commit/dc9df6540c08b1195f65530be0b1a0374d636c16 dc9df65
Branches : temp-ui-button-type-refactor
Author : Julian Eisel (Severin)
----------------------------------------
Add own derived struct for search buttons

A complication was that we sometimes change the button type after it's created.
So I had to add logic to reallocate the button if needed, so the derived data
can be used.

----------------------------------------
9 Paths Changed]]>
Sat, 02 May 2020 00:06:16 +0000 http://www.miikahweb.com/en/blender/git-logs/commit/dc9df6540c08b1195f65530be0b1a0374d636c16Julian Eisel