http://www.miikahweb.com/feed.php MiikaHweb - Blender Tmp-COW_InsertKeyframe_Fix Branch http://www.miikahweb.com/ MiikaHweb - Blender Tmp-COW_InsertKeyframe_Fix Branch fi Fri, 20 Sep 19 10:59:40 +0000 MiikaHweb RSS contact at miikahweb.com <![CDATA[[8451f3f]: WIP: Improved implementation of DEG_get_evaluated_rna_pointer...]]> http://www.miikahweb.com/en/blender/git-logs/commit/8451f3fabc88c2e8126c9e9b8560ce810c21d27e 8451f3f
Branches : tmp-COW_InsertKeyframe_Fix
Author : Joshua Leung (aligorith)
----------------------------------------
WIP: Improved implementation of DEG_get_evaluated_rna_pointer()

This now works by getting the RNA Path from the given PointerRNA to go from the
ID block to the data it points to, then uses this path to find the new data
relative to the COW ID.

Note: This currently still has all the debug prints left in - As can be seen,
I was testing this against the earlier PoseBone hack/special case. We may still
need to bring such special cases back in future, since looking up RNA Paths
like this can be slow.

----------------------------------------
2 Paths Changed]]>
Sat, 19 May 2018 17:12:26 +0000 http://www.miikahweb.com/en/blender/git-logs/commit/8451f3fabc88c2e8126c9e9b8560ce810c21d27eJoshua Leung
<![CDATA[[b8e44cc]: Cleanup: Remove temporary debugging code]]> http://www.miikahweb.com/en/blender/git-logs/commit/b8e44cc194d2ec1a8388485e11da163793816a9a b8e44cc
Branches : tmp-COW_InsertKeyframe_Fix
Author : Joshua Leung (aligorith)
----------------------------------------
Cleanup: Remove temporary debugging code

----------------------------------------
1 Path Changed]]>
Sat, 19 May 2018 17:27:51 +0000 http://www.miikahweb.com/en/blender/git-logs/commit/b8e44cc194d2ec1a8388485e11da163793816a9aJoshua Leung
<![CDATA[[d56df9d]: Add back temporary exception for pose bones in DEG_get_evaluated_rna_pointer...]]> http://www.miikahweb.com/en/blender/git-logs/commit/d56df9d1352070b4ab7e4faa7bebc01f384c67a5 d56df9d
Branches : tmp-COW_InsertKeyframe_Fix
Author : Joshua Leung (aligorith)
----------------------------------------
Add back temporary exception for pose bones in DEG_get_evaluated_rna_pointer()

Without the exception, adding new poses to pose libraries took several seconds
with only <= 4 bones selected. While we may still need this for other cases too,
since bones are such a common use case, it makes sense to provide some level
of optimisation for them.

----------------------------------------
1 Path Changed]]>
Sat, 19 May 2018 17:42:36 +0000 http://www.miikahweb.com/en/blender/git-logs/commit/d56df9d1352070b4ab7e4faa7bebc01f384c67a5Joshua Leung
<![CDATA[[57abe7b]: WIP COW Fix: Insert keyframe operators/api now queries depsgraph...]]> http://www.miikahweb.com/en/blender/git-logs/commit/57abe7b1327fc67bd23d4d9ae16c77160fc2e0e8 57abe7b
Branches : tmp-COW_InsertKeyframe_Fix
Author : Joshua Leung (aligorith)
----------------------------------------
WIP COW Fix: Insert keyframe operators/api now queries depsgraph for evaluated data

When using copy on write, insert keyframe operators were reading from old
bmain data instead of COW data. This meant that inserting keyframes would
often read old/stale data, resulting in invalid keyframes getting created
(e.g. from last transform operation, instead of actual current state).

This commit makes it so that keyframing operators will ask depsgraph for
the evaluated copy of the data, so that it can read values from that. It
introduces a new function - `DEG_get_evaluated_rna_pointer()`, which when
working correctly/fully, should work just like the other `DEG_get_evaluated_*()`
functions, except it lets you pass in an RNA Pointer.

However, currently, this is only done for Pose Bones (as a dirty hack, since this
is an important/pivotal requirement for production) and/or datablock
properties directly (since we can just use the DEG_get_evaluated_id() directly).
on the datablock.

Committing to a branch for now as this all needs more testing. More work to come
later at a more sane time of day!

----------------------------------------
15 Paths Changed]]>
Fri, 18 May 2018 18:36:48 +0000 http://www.miikahweb.com/en/blender/git-logs/commit/57abe7b1327fc67bd23d4d9ae16c77160fc2e0e8Joshua Leung