Blender Git Loki
Git Commits -> Revision 06de5be
Revision 06de5be by Antonis Ryakiotakis (master) March 17, 2014, 23:08 (GMT) |
Fix T39228 Gamma/lift/gain are burned out in the circular color pickers and value/lightness slider stops midway. Issue here is manyfold: Color wheel does not support properties with different soft min/max values than 1.0 (which after experimenting a little I left as is), and also color management is completely destroying the mapping between the value slider and the RNA property value range. To solve this I have disabled color management by setting the property to gamma corrected (only in RNA, Sequence editor coders please check!), otherwise it will just become a big mess of tracking where color comes from and what kind of color transforms it needs in different color pickers (if property has non normalized range etc). HSL is not really meant to represent colors outside a normalized space so I have disabled setting lightness above 1.0 in this model. This will work, however it is hacking a color picker to do something other than what it is supposed to do: pick a color from the screen accurately. Which means normalized values always. The non normalized colors picked for lift/gain/gamma through the pickers do not correspond to any accurate colors; they are rather a user friendly way to 'sort of' choose a color and a gamma with an indication of maximum value. I think that lift/gamma/gain nodes need a dedicated widget for this (besides it is quite clear that some options are written for that use case) -or- a separate gamma multiplier for the picked color (which should itself be in a normalized space) |
Commit Details:
Full Hash: 06de5be90e8b009c53b6fe3225085fcd4375f21f
Parent Commit: 7da2175
Lines Changed: +26, -18
5 Modified Paths:
/source/blender/blenlib/intern/math_color.c (+1, -1) (Diff)
/source/blender/editors/interface/interface_handlers.c (+5, -3) (Diff)
/source/blender/editors/interface/interface_regions.c (+1, -1) (Diff)
/source/blender/editors/interface/interface_widgets.c (+16, -10) (Diff)
/source/blender/makesrna/intern/rna_sequencer.c (+3, -3) (Diff)
/source/blender/editors/interface/interface_handlers.c (+5, -3) (Diff)
/source/blender/editors/interface/interface_regions.c (+1, -1) (Diff)
/source/blender/editors/interface/interface_widgets.c (+16, -10) (Diff)
/source/blender/makesrna/intern/rna_sequencer.c (+3, -3) (Diff)