Blender Git Loki

Git Commits -> Revision 4049225

Revision 4049225 by Philipp Oeser (master)
October 4, 2019, 13:31 (GMT)
Fix T70454: Environment Texture Node Properties "reload" and "packing" not working

The bug was basically just caused by a missing 'edit_image' and
'edit_image_user' pointer in context for
So adding the following there would be enough to fix the bug:
uiLayoutSetContextPointer(layout, "edit_image", &imaptr);
uiLayoutSetContextPointer(layout, "edit_image_user", &iuserptr);

However, I would suggest using the full-flegged uiTemplateImage (just as
'node_shader_buts_tex_image_ex' does -- instead of a "handmade" subset)
for the following consistency reasons:
- Layout was using single column for image textures, but not environment
- Save / Discard feature on editing the image was there for image
textures, but not environment textures
- Environment textures: Color Space was displayed on node (but not
- Environment textures: Animation / Sequence settings were displayed on
node (but not properties)

Cant think of a reason for _not_ displaying the whole set for
environment textures (just as for regular image textures)?

Maniphest Tasks: T70454

Differential Revision:

Commit Details:

Full Hash: 40492251f2ff7b82468d8b922d95c2af4b98264c
Parent Commit: d590db8
Lines Changed: +1, -44

Tehnyt: Miika HämäläinenViimeksi p?ivitetty: 07.11.2014 14:18 MiikaH:n Sivut a.k.a. MiikaHweb | 2003-2020