Blender Git Loki
Git Commits -> Revision 91270fb
Revision 91270fb by Sergey Sharybin (cycles-x) April 10, 2021, 12:08 (GMT) |
Cycles: Remove passes from BufferParams Now it is the Scene which is the source of truth for passes. The RenderBuffers will store pre-calculated offsets and strides which are set once when the passes are known. There are few things which are good: - Data is no longer duplicated, is clear where passes are to be accessed from. - Code which sues BufferParams can access offsets and strides directly, without re-calculating anything. - DenoiserBuferParams are removed, since it does not bring any new functionality. Some downsides: - Construction of new RenderBuffers is to be done with a bit more care now. - Passes needs to be passed to `get_pass_rect`. A bit annoying, and almost like the RenderBuffers is the wrong place for this function. - `set_pass_rect` is disabled for now. Is unclear whether it will be needed in the future, and what would it final placement be. |
Commit Details:
Full Hash: 91270fba1876bf48bc19b9b4e277d4cb7ff8ea4e
Parent Commit: cd98f5b
Lines Changed: +143, -206
15 Modified Paths:
/intern/cycles/blender/blender_session.cpp (+4, -3) (Diff)
/intern/cycles/integrator/denoiser.cpp (+0, -11) (Diff)
/intern/cycles/integrator/denoiser.h (+1, -19) (Diff)
/intern/cycles/integrator/denoiser_device.cpp (+4, -4) (Diff)
/intern/cycles/integrator/denoiser_device.h (+2, -2) (Diff)
/intern/cycles/integrator/denoiser_oidn.cpp (+7, -9) (Diff)
/intern/cycles/integrator/denoiser_oidn.h (+1, -1) (Diff)
/intern/cycles/integrator/path_trace.cpp (+5, -3) (Diff)
/intern/cycles/integrator/path_trace_work_cpu.cpp (+6, -11) (Diff)
/intern/cycles/integrator/path_trace_work_gpu.cpp (+28, -60) (Diff)
/intern/cycles/integrator/work_tile_scheduler.cpp (+2, -1) (Diff)
/intern/cycles/render/buffers.cpp (+54, -63) (Diff)
/intern/cycles/render/buffers.h (+26, -11) (Diff)
/intern/cycles/render/coverage.cpp (+2, -2) (Diff)
/intern/cycles/render/session.cpp (+1, -6) (Diff)
/intern/cycles/integrator/denoiser.cpp (+0, -11) (Diff)
/intern/cycles/integrator/denoiser.h (+1, -19) (Diff)
/intern/cycles/integrator/denoiser_device.cpp (+4, -4) (Diff)
/intern/cycles/integrator/denoiser_device.h (+2, -2) (Diff)
/intern/cycles/integrator/denoiser_oidn.cpp (+7, -9) (Diff)
/intern/cycles/integrator/denoiser_oidn.h (+1, -1) (Diff)
/intern/cycles/integrator/path_trace.cpp (+5, -3) (Diff)
/intern/cycles/integrator/path_trace_work_cpu.cpp (+6, -11) (Diff)
/intern/cycles/integrator/path_trace_work_gpu.cpp (+28, -60) (Diff)
/intern/cycles/integrator/work_tile_scheduler.cpp (+2, -1) (Diff)
/intern/cycles/render/buffers.cpp (+54, -63) (Diff)
/intern/cycles/render/buffers.h (+26, -11) (Diff)
/intern/cycles/render/coverage.cpp (+2, -2) (Diff)
/intern/cycles/render/session.cpp (+1, -6) (Diff)