Blender Git Loki
Git Commits -> Revision b3b4084
Revision b3b4084 by Sergey Sharybin (blender-v2.78c-release, fracture_modifier, fracture_modifier-master, temp-fracture-modifier-2.8) February 22, 2017, 14:08 (GMT) |
Blender 2.78c: Fix wrong cycles hair render results when using BVH motion steps This commit contains all commits required to get proper hair rendering with BVH motion steps enabled. The issue here was mainly coming from minimal pixel width feature which is quite commonly enabled in production shots. This feature will use some probabilistic heuristic in the curve intersection function to check whether we need to return intersection or not. This probability is calculated for every intersection check. Now, when we use multiple BVH nodes for curve primitives we increase probability of that primitive to be considered a good intersection for us. This is similar to increasing minimal width of curve. What is worst here is that change in the intersection probability fully depends on exact layout of BVH, meaning probability might change differently depending on a view angle, the way how builder binned the primitives and such. This makes it impossible to do simple check like dividing probability by number of BVH steps. Other solution might have been to split BVH into fully independent trees, but that will increase memory usage of all the static objects in the scenes, which is also not something desirable. For now used most simple but robust approach: store BVH primitives time and test it in curve intersection functions. This solves the regression, but has two downsides: - Uses more memory. which isn't surprising, and ANY solution to this problem will use more memory. What we still have to do is to avoid this memory increase for cases when we don't use BVH motion steps. - Reduces number of maximum available textures on pre-kepler cards. There is not much we can do here, hardware gets old but we need to move forward on more modern hardware.. |
Commit Details:
Full Hash: b3b4084073dd32fc6fa1b0bcf95122c9c43d73d4
Parent Commit: c6e4a81
Lines Changed: +87, -8
11 Modified Paths:
/intern/cycles/bvh/bvh.cpp (+10, -0) (Diff)
/intern/cycles/bvh/bvh.h (+2, -0) (Diff)
/intern/cycles/bvh/bvh_build.cpp (+36, -0) (Diff)
/intern/cycles/bvh/bvh_build.h (+4, -0) (Diff)
/intern/cycles/bvh/bvh_params.h (+1, -0) (Diff)
/intern/cycles/kernel/geom/geom_curve.h (+23, -5) (Diff)
/intern/cycles/kernel/kernel_textures.h (+1, -1) (Diff)
/intern/cycles/kernel/kernel_types.h (+2, -1) (Diff)
/intern/cycles/kernel/svm/svm_image.h (+0, -1) (Diff)
/intern/cycles/render/mesh.cpp (+7, -0) (Diff)
/intern/cycles/render/scene.h (+1, -0) (Diff)
/intern/cycles/bvh/bvh.h (+2, -0) (Diff)
/intern/cycles/bvh/bvh_build.cpp (+36, -0) (Diff)
/intern/cycles/bvh/bvh_build.h (+4, -0) (Diff)
/intern/cycles/bvh/bvh_params.h (+1, -0) (Diff)
/intern/cycles/kernel/geom/geom_curve.h (+23, -5) (Diff)
/intern/cycles/kernel/kernel_textures.h (+1, -1) (Diff)
/intern/cycles/kernel/kernel_types.h (+2, -1) (Diff)
/intern/cycles/kernel/svm/svm_image.h (+0, -1) (Diff)
/intern/cycles/render/mesh.cpp (+7, -0) (Diff)
/intern/cycles/render/scene.h (+1, -0) (Diff)