Blender Git Loki

Git Commits -> Revision f885306

Revision f885306 by Sergey Sharybin (master)
June 5, 2012, 09:57 (GMT)
Fix #31702: Drag and Drop parenting crashes Blender

Crash was caused by recent changes in parent drop operator which were
aimed to prevent parenting objects between different scenes (which probably
makes sense).

The problem was how it was checked if objects belongs to the same scene --
outliner tree with type ID_SCE was used for this which works pretty nice
for All Scenes outliner view. But in other view modes there is no scene
element in outliner tree which lead to some NULL pointer dereferences.

Currently resolved this by assuming that if there's no Scene parent element
in outliner tree parent and child belongs to the same scene which is active
scene. This is truth for current view modes of outliner but if it'll be
changed in the future this assumption shall be updated and re-implemented
with some smarter checks of which scene object from outliner belongs to.

Commit Details:

Full Hash: f885306bb8b12fb20817bd499fb52d9f072d6b55
SVN Revision: 47454
Parent Commit: ae81032
Lines Changed: +16, -2

2 Modified Paths:

/source/blender/editors/space_outliner/outliner_edit.c (+6, -1) (Diff)
/source/blender/editors/space_outliner/space_outliner.c (+10, -1) (Diff)
Tehnyt: Miika HämäläinenViimeksi päivitetty: 07.11.2014 14:18MiikaH:n Sivut a.k.a. MiikaHweb | 2003-2021