Blender Git Loki

GP UI: WIP Attempt to cleanup some weird alignment/nesting/spacing issues

It's unclear to my why all these fields seemed to be individually wrapped
in both a row and column layout, but with "align=True" enabled, causing
the widgets to be oddly separated in the UI

GP Eraser Panel: Expose button to activate eraser

It's currently impossible to activate the eraser in the 3D view otherwise
if you're using a mouse (unlikely for most serious 2D artists, but possible
for non-sculpting modellers/animators) or if your tablet doesn't have an
eraser end (IIRC some non-Wacom styluses may have this limitation)

Also noted that we should also expose the hard/soft mode, and/or strength
settings here too (as opposed to having these hardcoded and/or mapped to
hardcoded modifier keys only)

GP UI - 2D/3D Split: Move all 3D toolbar only panel code to space_view3d_toolbar.py

* All toolbar panels that are only used in the 3D view have now been
moved out of properties_gpencil_common.py, as they are *only* used
in that editor.

* Sculpt, Edit, and Eraser panel definiitions remain in the common file
for now, as it's still possible for these to be used in other editors
(at least in theory - there may be some new limitations I haven't found yet)

GP UI - 2D/3D Split: Split out the "Create Shapes" and "DrawingToolsPanel" into separate classes

The 3D/GP Object only used part of the old "DrawingToolsPanel" to
draw the "Shapes" panel, going so far as to use an empty label +
custom draw header function to dynamically change the label.

This commit properly fixes the code here by separating out the code for
the two use cases:
* The GP object case is now handled by a dedicated "GreasePencilCreateShapesPanel"
that only does the "Shapes" stuff
* I've reverted the other case back to the master version, as this is more
suitable for use by all the other 2D editors

Clean Boundary Fill: Clarify Labels/Tooltips

GP "Strokes Edit" Panel: Consolidate a few items in preparation for restoration of 2D GPencil (WIP)

The groupings here are not final, and can still be adjusted/scrapped.

1) Used "operator_menu_enum"'s in place of listing out all the modes of
certain operators with multiple modes. This brings those operators more
in line with the other ops here (and in other parts).

2) Fixed the code to not show 3D only operators if this panel gets used
anywhere else.

Cleanup: Style fixes

Cleanup: Move modal operator draw callbacks out of ED_gpencil.h

Turns out that these were only actually used from within the gpencil
module (i.e. they were defined in drawgpencil.c, and called from the
gpencil_<opname>.c files), so it's not even necessary to export these
function prototypes in the ED_gpencil.h header.

Cleanup: Remove color picker defines from headers

There's no need for these defines to be in any headers, as this operator
is entirely self-contained in its own file now.

Merge branch 'blender2.8' into greasepencil-object

Remove limitation of fill only colors

Now, when a fill brush is selected, the color picker shows all colors, not only fill colors. This makes the palette more consistent.

Fix enum after merge

The code has been moved to new header file, so new definitions were missed.

Merge branch 'blender2.8' into greasepencil-object

Conflicts:
source/blender/editors/object/object_modifier.c
source/blender/editors/space_outliner/outliner_tree.c
source/blender/makesdna/DNA_object_types.h

GP Toolbar UI: Move the "Eraser" and "Brush Appearance" panels to the Tools tab in Draw Mode

It was awkward having these in the "Options" tab, where they were
likely to get missed. This change will perhaps make more sense
after some of my other upcoming changes here.

Fix: GP Color Picker text positioning/sizing was using an absolute pixel size for an offset

This would break when changing the DPI settings

Cleanup: Simplify various bits of the GP Color Picker code

* Removed the redundant init() wrapper
* Got the "focus" text highlight working again (missed from previous commit)
* Removed some unused vars
* Clarified reason why poll fails

GP Color Picker: Highlight the color under the mouse

Previously, the color picker provided no feedback on which
color under the mouse would get applied when clicking.
It also wasn't that clear what the current active color
was.

This commit fixes this, making the UI feel more like a
standard Blender menu/popup, and less like a glitchy
non-interactive graphic, by drawing a highlight rect
behind the item currently under the mouse. By default,
the current/active color will be highlighted before
the mouse enters the panel.

Cleanup: Use BLI_rect functions instead of inlining boundbox range checks

GP Color Picker: Shrink thickness of outlines around color swatches

Now it looks less cartoonish, and more in line with other UI widgets

Fix error of render when select object not GP

The problem was the cache was not set to dirty if the active object was not a GP object.