Blender Git Loki

Fix reference counting error for world drag & drop

Error in 986d60490c0694941e27c070780c55f07b7b4842

Fix invalid arguments to ED_gizmotypes_snap_3d_context_ensure

Cleanup: remove unused includes in Compositor

And move unneeded includes in frequently used headers
to source files.

Slightly reduces compile time.

Cleanup: remove `this->` for `m_` prefixed members in Compositor

For cleaning old code style as new code usually omit it.

Cleanup: replace members `m_` prefix by `_` suffix in Compositor

To convert old code to the current convention and
use a single code style.

Cleanup: convert camelCase naming to snake_case in Compositor

To convert old code to the current convention and
use a single code style.

Cleanup: use `_` suffix for non-public data members in Compositor

For code style and clarity.

Fix Compositor stack use after scope

Caused by {rBf84fb12f5d72433780a96} after changing
`get_areas_to_render` to return a vector instead of a span.

Fix T90799: Box/Ellipse Mask node masking is off-centered

This is especially noticeable when using the default center with full
width and height as some borders are masked by 1 pixel.

The relative coordinates are now calculated respect the last ones
instead of the dimensions for centering, and the limits
are inclusive to mask more accurately.

Cleanup: Snap Context Refactor

Move runtime parameters out of context creation.

Not being able to choose another region and v3d limits the use of the
snap API.

Fix T92192: Inconsistent curve circle primitive direction

Switch sin and cosine so that the points in the circle have the same
direction in both radius and points modes.

Fix T92180: Curve subdivide incorrect result for poly splines

The node shifted all new points forward in the spline, so the first
point would appear to be removed.

Fix T88766 EEVEE: Missing glossy reflections with Shader to RGB & SSR is active.

This was due to the shading evaluation being outdated inside the ShaderToRGBA
glsl code.

Fix T89777 EEVEE: Contact Shadows causes wrong shading in Reflection Plane

The planar reflections being rendered at the same resolution as the HiZ max
buffer, do not need any uv correction during raytracing.

However, the GTAO horizon buffer being at output resolution do need the
uv factors in order to match the pixels visible on screen. To avoid many
complication, we increase the size of the GTAO texture up to the hiz buffer
size. This way, if planar reflections need GTAO the texture is big enough.
We change the viewport of the GTAO framebuffer for the main view in order
to not have to modify Uvs in many places.

Geometry Nodes: Material Index - minor cleanup

- Add a versioning comment
- Indexes to Indices

Geometry Nodes: Fields version of edge split node

This changes the edge split node to have a selection input, which is
more aligned with the other design changes. This loses the ability to
split edges based on an angle, but the edge angle can be added as a
field input node in the future, which will make for a much more
flexible system.

Differential Revision: https://developer.blender.org/D12829

Geometry Nodes: Make attribute capture work on instances

Previously the attribute capture node only worked on realized geometry,
which was very confusing when other nodes worked on each individual
instance. The realize instances node is the way to explicitly change
between the two behaviors. Addresses T92155.

Differential Revision: https://developer.blender.org/D12841

Geometry Nodes: Rotate Instances Node

Adds a node that can rotate each of a geometry's instances in global
(to the modifier object) or local space (of each point) by a specified
angle around a pivot point.

In the future, separating the local-global choice for the pivot and the
rotation might be useful. However, for now the node is kept simple.

Differential Revision: https://developer.blender.org/D12682

Fix T92185: GPencil memory leak removing stroke from python

The API was not removing the weights, points and traingulation data. Only it was removing the stroke itself.

Cleanup: Remove data duplication from SMAA lookup tables

These 2 large tables, `areaTexBytes` and `searchTexBytes`, contributed
~176kb worth of duplicate data into the `blender` executable due to the
header being used in multiple places. We were lucky that only 2
translation units had included this header so only 1 duplicate copy of
each was wasted.

Define the tables as `extern` to address this.

Reviewed By: fclem

Differential Revision: https://developer.blender.org/D12723