Blender Git Loki

Cleanup: Remove unused DerivedMesh functions

Geometry Nodes: Support instances in the delete geometry node

Ever since the instance domain was added, this was exposed, it just
didn't do anything. This patch implements the instances domain in the
delete and separate geometry nodes, where it acts on the top-level
instances.

We act on a mutable instances input, with the idea that eventually
copy on write attribute layers will make this less expensive. It also
allows us to keep the instance references in place and to do less
work in some situations.

Ref T93554

Differential Revision: https://developer.blender.org/D13565

Geometry Nodes: Accumulate Fields Node

This function node creates a running total of a given Vector, Float, or
Int field.

Inputs:
- Value: The field to be accumulated
- Group Index: The values of this input are used to aggregate the input
into separate 'bins', creating multiple accumulations.
Outputs:
- Leading and Trailing: Returns the running totals starting
at either the first value of each accumulations or 0 respectively.
- Total: Returns the total accumulation at all positions of the field.

There's currently plenty of duplicate work happening when multiple outputs
are used that could be optimized by a future refactor to field inputs.

Differential Revision: https://developer.blender.org/D12743

Fix: Issues with attribute comparison in geometry nodes tests

A few typos in 17770192fb0c5fddda lead to an incorrect count of custom
data layers in the test meshes. We only want to consider layers that are
not anonymous, and there was a copy and paste mistake.

Nodes: Composite: UI fixes to time node

- Use default size consistent with other curve nodes
- Use column instead of row for properties

Fix T94113: Local view + Geometry Nodes is broken for instances

`GeometrySet::compute_boundbox_without_instances` may not initialize min
max in some cases such as meshes without vertices.

This can result in a Bounding Box with impossible dimensions
(min=FLT_MAX, max=-FLT_MAX).

So repeat the same solution seen in `BKE_object_boundbox_calc_from_mesh`
and set boundbox values to zero.

Reviewed By: HooglyBoogly

Differential Revision: https://developer.blender.org/D13664

Cleanup: Remove dead code

Nodes: Cleanup: Remove no op registration functions

All these function paramaters are set to NULL so they arent necessary.

Reviewed By: HooglyBoogly, JacquesLucke

Differential Revision: https://developer.blender.org/D13686

gpu.types.GPUOffScreen: accept format argument for color texture

Some projects need more than 8-bit RGBA off-screen, so add the ability to
accept color format and defaults to RGBA8 so existing code should not be
affected.

Currently supported formats:
- RGBA8 (default)
- RGBA16
- RGBA16F
- RGBA32F

Reviewed By: mano-wii

Differential Revision: https://developer.blender.org/D13650

Fix: VSE colormix blend factor not working

Blend factor was used to adjust alpha of background image, which is not
correct. This was done in fdee84fd567a where another change was, that
background alpha is copied into result, which is correct.

Apply blend factor to foreground image alpha channel.

Fix T94422: Shading/Normals break on array modifier caps

The array modifier does not necessarily tag normals dirty.
If it doesnt, normals are recalculated "internally" using the offset ob
transform. This was happening for the array items, but not for the caps.

Now do the same thing for caps.

Maniphest Tasks: T94422

Differential Revision: https://developer.blender.org/D13681

Fix T94453: Weld modifier crash after recent cleanup

I had assumed that the span's size was the same as the length variable.
In the future, separate lengths could be removed in favor of using
lengths directly from spans.

Nodes: Convert shader, shader category nodes to c++

Also add file namespace

This is needed to use new node APIs

Differential Revision: https://developer.blender.org/D13684

Cleanup: clang-tidy

Fixes two instances of `-Wunused-but-set-variable`

There are several more of these but these were low hanging
and noisy with one being in a header functions.

Cleanup: clang-tidy

- modernize-deprecated-headers
- modernize-redundant-void-arg

Missed in rB11ac276caaa6e6d42176452526af97cf972abb5f

Cleanup: Remove unused node tree "local sync" functions

Cleanup: Use indices instead of pointers

This improves code readability.

Take the opportunity and improve the comments too.

Cleanup: Return early, organize variable declarations

Nodes: Enable unity build for function nodes

Unity build saves 5 seconds off the total build time when compiling `bf_nodes_function`.
Total build times went from 25s to 20s (20% reduction),
tested with ninja on linux running i5 8250U.

Nodes: Add bf_nodes_function module

In the future this will be used to support unity builds for function nodes

Differential Revision: https://developer.blender.org/D13682