Blender Git Loki

Cleanup: removed shadowed variable

Geometry Nodes: reduce number of scheduled nodes in evaluator

Previously, there were a couple of cases where nodes were scheduled when
that was not really necessary. This change doesn't seem to have a big impact
on performance, but simplifies the code a bit.

Merge branch 'blender-v3.0-release'

Fix T93352: Material previews lost render samples

There are few layers of things which lead to the situation
of more noisy material preview: the do-version of the
preview.blend did not happen (at least from the Python
side as we did not investigate the C side deep). This made
Cycles to use default integrator settings for the preview
file ever since the Cycles X was merged. Those settings are
adaptive sampling with max 4K samples, noise threshold 0.01.
Opening the file in Blender 3.0 for edit did run the versioning
code which effectively lowered the number of samples used for
rendering.

This change makes it so the preview file is configured with
the exact effective settings as seen by Cycles prior to the
file was re-saved (adaptive sampling with the parameters noted
above).

This fix does not chaneg the fact that the versioning code is
not used for preview.blend, it only solves the regression in
the quality of previews.

The fix is done and reviewed with collaboration with Dalai and Sergey.

Geometry Nodes: decouple Delete Geometry node from Mask modifier

This dependency was a bit ugly and the functions from the mask modifier
did a few things that we don't need in the Delete Geometry node:
* The mask modifier uses `CustomData_copy_data` which the node doesn't need.
* The mask modifier checks for `-2` in some values, but this special value is
not used by the node.

Differential Revision: https://developer.blender.org/D13335

CMake: add WITH_UNITY_BUILD option to improve compile times

Unity builds are only used in the `bf_nodes_geometry` module for now.
This module has been prepared to support unity builds already.
Usually, there is a 2-4x speedup when building `bf_nodes_geometry`
compared to without unity builds (e.g. 145s to 55s).

For more information about how unity builds work and how they help
with compile times, see D13341.

Differential Revision: https://developer.blender.org/D13341

Assets: Sanitize threaded preview creation with undo

Basically, this fixes disappearing previews when editing asset metadata
or performing undo/redo actions.

The preview generation in a background job will eventually modify ID
data, but the undo push was done prior to that. So obviously, an undo
then would mean the preview is lost.

This patch makes it so undo/redo will regenerate the preview, if the preview
rendering was invoked but not finished in the undone/redone state.

The preview flag PRV_UNFINISHED wasn't entirely what we needed. So I had to
change it to a slightly different flag, with different semantics.

Cleanup: Renamed DefaultDrawingMode ImageSpaceDrawingMode.

Explains more what it does, not how it is used.

Assets: Sanitize threaded preview creation with undo

Basically, this fixes disappearing previews when editing asset metadata
or performing undo/redo actions.

The preview generation in a background job will eventually modify ID
data, but the undo push was done prior to that. So obviously, an undo
then would mean the preview is lost.

This patch makes it so undo/redo will regenerate the preview, if the preview
rendering was invoked but not finished in the undone/redone state.

The preview flag PRV_UNFINISHED wasn't entirely what we needed. So I had to
change it to a slightly different flag, with different semantics.

ImageEngine: Remove unneeded check for tiled image.

Regular images are also tiled images, but with a default tile that leads
to the same result.

Tests: exclude anonymous attributes from mesh comparison

The set of anonymous attributes on a geometry is not visible to the user.

Cleanup: `IDTypeInfo` new `asset_type_info` member.

Two issues addressed here:

I) `asset_type_info` is sub-data, not a callback. Therefore, move it
before the callbacks in the `IDTypeInfo` struct.

II) More important, initialize this new attribute in *ALL* `IDTypeInfo`
instances. No member of this struct should ever be left implicitely
uninitilazed, ever.

Aftermath of rBa84f1c02d251.

Fix T93345: missing null check for geometry nodes logger

Cleanup: Add info about attributes init in Mesh IDTypeInfo after conversion to C++.

rB6002914f141f totally lost those info, in C++ we use comments by
convention.

Cleanup: use lowercase in private functions.

Cleanup: use lowercase in private functions.

Cleanup: use nullptr

Merge branch 'blender-v3.0-release'

Cleanup: Silent compilation warning in draw_manager.

Fix crash when opening search menu.

Asset install bundle poll didn't check the space it was running in and
assumed that it was always running in file browser.