Blender Git Loki

Porting more GP Modifiers

* Opacity modifier
* Color modifier
* Thickness modifier
* Tint modifier

Cleanup: Remove unused function

Fix: GP modifiers not updating when properties changed

Added back an explicit call to BKE_gpencil_batch_cache_dirty()
in the rna update callback for GPencil modifier properties.

However, instead of polluting the general rna_Modifier_update(),
this time we do this in a special wrapper/update callback for
dedicated GP modifier usage.

I'm unsure why the depsgraph isn't properly updating this case
- there's probably a missing relation between modifier properties
and GP ubereval (which calls the tagging), but where?!

GP Modifier: Set up stubs for geometry modifiers too

GP Modifiers: Fully ported Noise modifier over to new system

Fix: "deformStrokes(..., bGPDframe *)" callback should really have been "deformStroke(..., bGPDstroke *)" instead

Cleanup - Various cleanups for GP modifier files

* Remove redundant checks
* Use M_PI_2 instead of hardcoding a magic number
* Fix license text year info
* Properly handle new palette creation in Tint modifier

Cleanup: De-duplicate mode checking macros for GPencil

Cleanup - Move helper functions for GP modifiers into the modifiers module

Cleanup - Use existing vertex groups function instead of defining out own

Fix compiler warning about const vs non-const

Fix "Apply Modifier" operator to use the new callbacks

GP Modifiers - Change all applyModifier callbacks to bakeModifierGP callbacks

ModifierTypeInfo - Add 3 dedicated callbacks to support GP modifier evaluation and operations

* deformStrokes - Handles the "stroke" modifiers currently evaluated in
BKE_gpencil_stroke_modifiers() - e.g. Thickness, Noise

* generateStrokes - Handles the "geometry" modifiers currently evaluated
in BKE_gpencil_geometry_modifiers() - e.g. Array

* bakeModifierGP - Dedicated callback for hosting the code currently
wrongly-placed in applyModifier. This gets called
when pressing the "Apply" button on a GP modifier.

Compile fix: Missed a reference in previous commit

TODO: Calls to BKE_gpencil_layer_delframe() need to trigger a refresh

Cleanup - Remove direct BKE_gpencil_batch_cache_dirty() code in favor of depsgraph tagging

Cleanup: Eliminate BKE_gpencil_batch_cache_alldirty()

This accessed the global G.main directly, which we're trying to remove

Fix: Version patching code was creating extra GP datablocks and throwing them away

After modifying the BKE_object_add() function to create a new GP datablock
by default, this change in behaviour would cause problems for the version
patching code fixing the old scene->gpd.

Cleanup - Remove unused var

Cleanup - Style