Blender Git Commit Log

Git Commits -> Revision 3e158b0

May 8, 2018, 14:28 (GMT)
Remove VFX Modifiers + Defunct "DOF" Code

* As per code reviews (see T54721 and T54769), it was decided that the "VFX Modifiers"
should not be in the modifiers stack, as they are not really modifiers. Instead, they
are more like placeholders for shader effects on the object. For now, we simply remove
these from the code, with a view towards designing a more general solution for all
object types in 2.8 in future (e.g. as a "Viewport Effects" tab or similar in the Properties
Editor)

* Also removed the "DOF" code. This was trying to copy what was done for Eevee, but the
results were low quality, and the relevant code paths were already commented out.
This code is also removed in this commit, as it depended a lot on many of the things
put in place for the VFX modifiers, making removal of the VFX buffers complicated.
Since it's not used now, it's not a big loss. Besides, with version control, we can
bring this back in future.

NOTE: Blender still doesn't compile - there are still too many extra buffers hanging around
that need to be removed

Commit Details:

Full Hash: 3e158b0a46bf74bd3453ddfbf65957c41cfcf428
Parent Commit: 44a4ed9
Lines Changed: +16, -2342

16 Deleted Paths:

/source/blender/draw/engines/gpencil/gpencil_depth_of_field.c (+0, -285)
/source/blender/draw/engines/gpencil/gpencil_vfx.c (+0, -566)
/source/blender/draw/engines/gpencil/shaders/gpencil_dof_frag.glsl (+0, -269)
/source/blender/draw/engines/gpencil/shaders/gpencil_dof_vert.glsl (+0, -100)
/source/blender/draw/engines/gpencil/shaders/gpencil_flip_frag.glsl (+0, -27)
/source/blender/draw/engines/gpencil/shaders/gpencil_gaussian_blur_frag.glsl (+0, -30)
/source/blender/draw/engines/gpencil/shaders/gpencil_light_frag.glsl (+0, -70)
/source/blender/draw/engines/gpencil/shaders/gpencil_pixel_frag.glsl (+0, -50)
/source/blender/draw/engines/gpencil/shaders/gpencil_swirl_frag.glsl (+0, -70)
/source/blender/draw/engines/gpencil/shaders/gpencil_wave_frag.glsl (+0, -40)
/source/blender/modifiers/intern/MOD_gpencilblur.c (+0, -87)
/source/blender/modifiers/intern/MOD_gpencilflip.c (+0, -86)
/source/blender/modifiers/intern/MOD_gpencillight.c (+0, -119)
/source/blender/modifiers/intern/MOD_gpencilpixel.c (+0, -87)
/source/blender/modifiers/intern/MOD_gpencilswirl.c (+0, -118)
/source/blender/modifiers/intern/MOD_gpencilwave.c (+0, -88)

12 Modified Paths:

/source/blender/blenkernel/BKE_modifier.h (+0, -2) (Diff)
/source/blender/draw/CMakeLists.txt (+0, -7) (Diff)
/source/blender/draw/engines/gpencil/gpencil_cache_utils.c (+1, -1) (Diff)
/source/blender/draw/engines/gpencil/gpencil_engine.c (+2, -103) (Diff)
/source/blender/draw/engines/gpencil/gpencil_engine.h (+3, -80) (Diff)
/source/blender/editors/interface/interface_templates.c (+10, -14) (Diff)
/source/blender/editors/space_outliner/outliner_draw.c (+0, -10) (Diff)
/source/blender/makesdna/DNA_modifier_types.h (+0, -6) (Diff)
/source/blender/makesrna/intern/rna_modifier.c (+0, -7) (Diff)
/source/blender/modifiers/CMakeLists.txt (+0, -6) (Diff)
/source/blender/modifiers/intern/MOD_util.c (+0, -7) (Diff)
/source/blender/modifiers/MOD_modifiertypes.h (+0, -7) (Diff)
By: Miika HämäläinenLast update: Nov-07-2014 14:18MiikaHweb | 2003-2021