Blender Git Loki
Git Commits -> Revision 3126f85
Revision 3126f85 by Dalai Felinto (master) June 7, 2018, 10:56 (GMT) |
Fix T55062: Depsgraph: Crash with COW with EEVEE viewport We now remove the shader for every update. So at the moment the whole point of UBO (Uniform Buffer Objects) is that they are more efficient than individual uniforms. Next steps is a harmless refactor to stopping UBO from referring to original data in the UBO, and simply copying it. It would also be interesting to make the final shader more granular as far as the library and required functions are concerned. Even if this doesn't impact performance, it should give us smaller easy to debug shaders (a simple shader now has > 5k lines!). If performance for animated values is measureable slower after this commit we can port the shader creation CPU side to the depsgraph - localizing the tree, hashing, lookup, ... Additionally we can stick to update the UBO when the material changes but not its topology. This is very trick because of localized trees. So we will only re-visit this if profiling hints at any benefit from it. |
Commit Details:
Full Hash: 3126f85d26448d7e8698724a563e0f5a08f4f34f
Parent Commit: d147437
Lines Changed: +1, -19
1 Modified Path:
/source/blender/makesrna/intern/rna_nodetree.c (+1, -19) (Diff)