Blender Git Loki
Git Commits -> Revision 338c106
Revision 338c106 by Hans Goudey (master) December 5, 2021, 21:45 (GMT) |
Cleanup: Remove unnecessary node type callbacks for drawing Currently there are a few callbacks on `bNodeType` that do the same thing for every node type except reroutes and frame nodes. Having a callback for basic things complicates code and makes it harder to understand, and reroutes and frames are special cases in larger way. Arguably frame nodes shouldn't even be drawn like regular nodes, given that it adds a case of O(N^2) looping through all nodes. "Unrolling" the callbacks makes it easier to see what's happening, and therefore easier to optimize. Differential Revision: https://developer.blender.org/D13463 |
Commit Details:
Full Hash: 338c1060d5d7b6a8bd3ec5632f543738de4c103c
Parent Commit: 0578921
Lines Changed: +141, -200
6 Modified Paths:
/source/blender/blenkernel/BKE_node.h (+0, -21) (Diff)
/source/blender/editors/space_node/drawnode.cc (+30, -141) (Diff)
/source/blender/editors/space_node/node_draw.cc (+91, -29) (Diff)
/source/blender/editors/space_node/node_edit.cc (+1, -1) (Diff)
/source/blender/editors/space_node/node_intern.hh (+10, -2) (Diff)
/source/blender/editors/space_node/node_select.cc (+9, -6) (Diff)
/source/blender/editors/space_node/drawnode.cc (+30, -141) (Diff)
/source/blender/editors/space_node/node_draw.cc (+91, -29) (Diff)
/source/blender/editors/space_node/node_edit.cc (+1, -1) (Diff)
/source/blender/editors/space_node/node_intern.hh (+10, -2) (Diff)
/source/blender/editors/space_node/node_select.cc (+9, -6) (Diff)