Blender Git Loki

Git Commits -> Revision 40e2942

Revision 40e2942 by Antonis Ryakiotakis (master)
February 14, 2012, 13:25 (GMT)
Fix related to #30152, rainbow colours produced when loading hdr image to 3D viewport/ the Nyan cat bug.

Issue is caused by scaling for power of 2 dimensions and mipmapping that happens through GLU. It looks like the library cannot handle float colour values above 1.0 correctly. Since we are close to release I will just clamp the srgb result for now even though it will result in a small performance loss for 16 bit textures only.

I tried a few things before that, glGenerateMipmaps + no scaling (supported for 2.0 GL hardware and up), or using our own scaling instead of glu among them which worked very nicely and gave a speedup too. However, since we are close to release and there may be issues with GPU mipmap generation, see:

http://www.gamedev.net/topic/495747-another-glgeneratemipmap-question/
(old discussion but better be sure than sorry)

I went for the most compatible solution. Maybe after release this can be tested if other devs agree.

Commit Details:

Full Hash: 40e2942f259f9de59fcf93fc99121ff46f630398
SVN Revision: 44108
Parent Commit: 6825577
Lines Changed: +13, -1

3 Modified Paths:

/source/blender/gpu/intern/gpu_draw.c (+5, -1) (Diff)
/source/blender/imbuf/IMB_imbuf.h (+1, -0) (Diff)
/source/blender/imbuf/intern/divers.c (+7, -0) (Diff)
Tehnyt: Miika HämäläinenViimeksi päivitetty: 07.11.2014 14:18MiikaH:n Sivut a.k.a. MiikaHweb | 2003-2021