Blender Git Loki
Git Commits -> Revision 57abe7b
Revision 57abe7b by Joshua Leung (tmp-COW_InsertKeyframe_Fix) May 18, 2018, 18:36 (GMT) |
WIP COW Fix: Insert keyframe operators/api now queries depsgraph for evaluated data When using copy on write, insert keyframe operators were reading from old bmain data instead of COW data. This meant that inserting keyframes would often read old/stale data, resulting in invalid keyframes getting created (e.g. from last transform operation, instead of actual current state). This commit makes it so that keyframing operators will ask depsgraph for the evaluated copy of the data, so that it can read values from that. It introduces a new function - `DEG_get_evaluated_rna_pointer()`, which when working correctly/fully, should work just like the other `DEG_get_evaluated_*()` functions, except it lets you pass in an RNA Pointer. However, currently, this is only done for Pose Bones (as a dirty hack, since this is an important/pivotal requirement for production) and/or datablock properties directly (since we can just use the DEG_get_evaluated_id() directly). on the datablock. Committing to a branch for now as this all needs more testing. More work to come later at a more sane time of day! |
Commit Details:
Full Hash: 57abe7b1327fc67bd23d4d9ae16c77160fc2e0e8
Parent Commit: de7635f
Lines Changed: +122, -47
15 Modified Paths:
/source/blender/depsgraph/DEG_depsgraph_query.h (+4, -0) (Diff)
/source/blender/depsgraph/intern/depsgraph_query.cc (+39, -0) (Diff)
/source/blender/editors/animation/anim_channels_defines.c (+8, -3) (Diff)
/source/blender/editors/animation/anim_filter.c (+1, -0) (Diff)
/source/blender/editors/animation/keyframing.c (+34, -24) (Diff)
/source/blender/editors/animation/keyingsets.c (+2, -1) (Diff)
/source/blender/editors/armature/pose_utils.c (+1, -1) (Diff)
/source/blender/editors/gpencil/gpencil_convert.c (+8, -7) (Diff)
/source/blender/editors/include/ED_anim_api.h (+1, -0) (Diff)
/source/blender/editors/include/ED_keyframing.h (+4, -2) (Diff)
/source/blender/editors/interface/interface_anim.c (+8, -3) (Diff)
/source/blender/editors/space_action/action_edit.c (+2, -1) (Diff)
/source/blender/editors/space_graph/graph_edit.c (+2, -1) (Diff)
/source/blender/editors/transform/transform_conversions.c (+4, -2) (Diff)
/source/blender/python/intern/bpy_rna_anim.c (+4, -2) (Diff)
/source/blender/depsgraph/intern/depsgraph_query.cc (+39, -0) (Diff)
/source/blender/editors/animation/anim_channels_defines.c (+8, -3) (Diff)
/source/blender/editors/animation/anim_filter.c (+1, -0) (Diff)
/source/blender/editors/animation/keyframing.c (+34, -24) (Diff)
/source/blender/editors/animation/keyingsets.c (+2, -1) (Diff)
/source/blender/editors/armature/pose_utils.c (+1, -1) (Diff)
/source/blender/editors/gpencil/gpencil_convert.c (+8, -7) (Diff)
/source/blender/editors/include/ED_anim_api.h (+1, -0) (Diff)
/source/blender/editors/include/ED_keyframing.h (+4, -2) (Diff)
/source/blender/editors/interface/interface_anim.c (+8, -3) (Diff)
/source/blender/editors/space_action/action_edit.c (+2, -1) (Diff)
/source/blender/editors/space_graph/graph_edit.c (+2, -1) (Diff)
/source/blender/editors/transform/transform_conversions.c (+4, -2) (Diff)
/source/blender/python/intern/bpy_rna_anim.c (+4, -2) (Diff)