Blender Git Loki

Git Commits -> Revision 70160f4

Revision 70160f4 by Hans Goudey (lineart-shadow)
December 8, 2021, 06:53 (GMT)
Fix T93521: Single point NURBS crash in resample node

The resample node didn't handle the case of when a spline didn't have
any evaluated points. For poly and Bezier splines we should never hit
this case, but it is expected when the number of NURBS control points
is smaller than its order, so we have to handle the case here.

It's not that obvious what to do in this case, there are a few options:
- Remove the bad splines from the result
- Generate empty splines for those inputs
- Skip resampling the bad splines, copy them to the result
- Arbitrarily generate single point splines

I chose option three, just skipping the "bad" splines. Since the node
already has a selection input, this can be described by just extending
that. "Splines with no evaluated points are implicitly deselected."
The first option would probably be valid too though.

Differential Revision:

Commit Details:

Full Hash: 70160f4bc2ff90cd5300b80db983fb4621fb086a
Parent Commit: 6acf745
Committed By: YimingWu
Lines Changed: +3, -3

1 Modified Path:

/source/blender/nodes/geometry/nodes/ (+3, -3) (Diff)
Tehnyt: Miika HämäläinenViimeksi päivitetty: 07.11.2014 14:18MiikaH:n Sivut a.k.a. MiikaHweb | 2003-2021