Blender Git Loki

Git Commits -> Revision 74cc397

Revision 74cc397 by Bastien Montagne (master)
May 28, 2014, 16:55 (GMT)
Fix T40405: Blender crashes on FBX export instantly.
Better fix than rBbef5cb3aa2e5a: consider edges between faces with opposed normals as sharp.

In fact, previous code was broken more deeply in this case (inconsistent normals across
a 'smooth fan') - some loop normals would even never be computed!

Fixing this is possible (even wrote it, actually), but this adds more complexity
to a piece of code that is already awfully complicated, *and* normals in that kind
of smooth fan do not make much sense anyway. So simpler and nicer results with
assuming sharp edges between such 'opposed' faces!

Note that there is some face (loop) ordering black magic at work here, added more comments
to try to explain how and why all this works.

As a bonus, we do not need to check for already computed loop normals anymore, since we
know each 'smooth fan' will be walked once, and only once.

Commit Details:

Full Hash: 74cc3974fea0422343b09bdd61e4d3924c62940a
Parent Commit: 9913da2
Lines Changed: +30, -16

2 Modified Paths:

/source/blender/blenkernel/intern/mesh_evaluate.c (+13, -14) (Diff)
/source/blender/bmesh/intern/bmesh_mesh.c (+17, -2) (Diff)
Tehnyt: Miika HämäläinenViimeksi päivitetty: 07.11.2014 14:18MiikaH:n Sivut a.k.a. MiikaHweb | 2003-2021