Blender Git Loki
Git Commits -> Revision 860e25f
Revision 860e25f by Bastien Montagne (master) September 15, 2015, 11:57 (GMT) |
Fix T46093: Thumbnails/previews of materials/textures not displaying in Blender filebrowser when only one thread is available. Using the global scheduler here is not a really good idea - `filelist_cache_previewf()` is not a short task that run once, but it's a loop that keeps cheking for work in a TODO queue. This means it won't quickly allow other tasks to start, so it should not be in the global scheduler. In fact, asynchronous tasks (that is, tasks that will live for quite a bit of time, and often sleep a lot) should never use global scheduler, they would steal computing resources from heavy-duty, short-time living ones - and possibly even completely stall threaded tasks (if all worker threads are executing long-life tasks...). We could probably even completely bypass the scheduler/task thing here (and directly use threads), but it does not have that much of an over-head, and still offers easy handling of threading stuff... |
Commit Details:
Full Hash: 860e25fe29c3f6732860c23dccb1f4813d4e387e
Parent Commit: 0c2be4d
Lines Changed: +6, -2
1 Modified Path:
/source/blender/editors/space_file/filelist.c (+6, -2) (Diff)