Blender Git Loki

Git Commits -> Revision 935e241

Revision 935e241 by Bastien Montagne (master)
February 23, 2016, 15:38 (GMT)
Fix (unreported) crash when opening a file from splash screen when 'load UI' option is disabled.

Took me some time to figure out what was going on here... Was again that delayed button
callback stuff (`ui_apply_but_funcs_after()`), first calling button op, and then
its callback func.

Issue was that 'open file' op (through call to `WM_file_read()`) would clear
the splash screen (as more or less the entire 'dynamic' UI), but callback func of that splash
(`wm_block_splash_refreshmenu()`) would still try to access that freed menu's region.

So, root of the issue seems to be that setting context's wm/win/etc. would not clear
context's menu pointer (while clearing all other 'sub' pointers). I could not find
nor imagine any case where this behavior could be desired, so simply added nullification
of that pointer when setting context's wm/win/etc.

Note that crash was due to read-after-free, infuriating debug builds with asan,
but seems like release builds never actually crashed on it.

Commit Details:

Full Hash: 935e241fa6ea095493ade5d5403c9ac55c18d5ef
Parent Commit: 125d5d2
Lines Changed: +5, -0

1 Modified Path:

/source/blender/blenkernel/intern/context.c (+5, -0) (Diff)
Tehnyt: Miika HämäläinenViimeksi päivitetty: 07.11.2014 14:18MiikaH:n Sivut a.k.a. MiikaHweb | 2003-2021