Blender Git Loki
Git Commits -> Revision ab2026b
Revision ab2026b by Joshua Leung (master) June 22, 2011, 11:41 (GMT) |
Animation Channel Filtering Refactor - Part 3 (Visibility Flag Split) * This (big) commit is aimed at cleaning up the filtering flags used by the animation channel filtering code. The list of filtering flags has been growing a bit "organically" since it's humble origins for use in the Action Editor some 3 years (IIRC) ago now during a weekend hackathon. Obviously, some things have ended up tacked on, while others have been the product of other flag options. Nevertheless, it was time for a bit of a spring clean! * Most notably, one area where the system outgrown its original design for the Action Editor was in terms of the "visibility" filtering flag it was using. While in the Action Editor the concept of what channels to include was strictly dictated by whether the channel hierarchy showed it, in the Graph Editor this is not always the case. In other words, there was a difference between the data the channels represented being visible and the channels for that data being visible in the hierarchy. Long story short: this lead to bug report [#27076] (and many like it), where if you selected an F-Curve, then collapsed the Group it was in, then even after selecting another F-Curve in another Group, the original F-Curve's properties would still be shown in the Properties Region. The good news is that this commit fixes this issue right away! * More good news will follow, as I start checking on the flag usage of other tools, but I'm committing this first so that we have a stable reference (of code similar to the old buggy stuff) on which we can fall back to later to find bugs (should they pop up). Anyways, back to the trenches! |
Commit Details:
Full Hash: ab2026bf4271ba316ffe621eb142091127ee1cf0
SVN Revision: 37728
Parent Commit: 11c0ee5
Lines Changed: +275, -225
22 Modified Paths:
/source/blender/editors/animation/anim_channels_defines.c (+2, -5) (Diff)
/source/blender/editors/animation/anim_channels_edit.c (+40, -20) (Diff)
/source/blender/editors/animation/anim_deps.c (+1, -1) (Diff)
/source/blender/editors/animation/anim_filter.c (+55, -62) (Diff)
/source/blender/editors/animation/keyframes_draw.c (+1, -1) (Diff)
/source/blender/editors/animation/keyframes_edit.c (+2, -2) (Diff)
/source/blender/editors/include/ED_anim_api.h (+46, -12) (Diff)
/source/blender/editors/space_action/action_draw.c (+2, -2) (Diff)
/source/blender/editors/space_action/action_edit.c (+19, -19) (Diff)
/source/blender/editors/space_action/action_select.c (+15, -15) (Diff)
/source/blender/editors/space_graph/graph_draw.c (+2, -2) (Diff)
/source/blender/editors/space_graph/graph_edit.c (+22, -22) (Diff)
/source/blender/editors/space_graph/graph_select.c (+11, -11) (Diff)
/source/blender/editors/space_graph/graph_utils.c (+10, -6) (Diff)
/source/blender/editors/space_graph/space_graph.c (+1, -1) (Diff)
/source/blender/editors/space_nla/nla_buttons.c (+2, -1) (Diff)
/source/blender/editors/space_nla/nla_channels.c (+4, -4) (Diff)
/source/blender/editors/space_nla/nla_draw.c (+2, -2) (Diff)
/source/blender/editors/space_nla/nla_edit.c (+22, -22) (Diff)
/source/blender/editors/space_nla/nla_select.c (+5, -4) (Diff)
/source/blender/editors/transform/transform_conversions.c (+9, -9) (Diff)
/source/blender/editors/transform/transform_generics.c (+2, -2) (Diff)
/source/blender/editors/animation/anim_channels_edit.c (+40, -20) (Diff)
/source/blender/editors/animation/anim_deps.c (+1, -1) (Diff)
/source/blender/editors/animation/anim_filter.c (+55, -62) (Diff)
/source/blender/editors/animation/keyframes_draw.c (+1, -1) (Diff)
/source/blender/editors/animation/keyframes_edit.c (+2, -2) (Diff)
/source/blender/editors/include/ED_anim_api.h (+46, -12) (Diff)
/source/blender/editors/space_action/action_draw.c (+2, -2) (Diff)
/source/blender/editors/space_action/action_edit.c (+19, -19) (Diff)
/source/blender/editors/space_action/action_select.c (+15, -15) (Diff)
/source/blender/editors/space_graph/graph_draw.c (+2, -2) (Diff)
/source/blender/editors/space_graph/graph_edit.c (+22, -22) (Diff)
/source/blender/editors/space_graph/graph_select.c (+11, -11) (Diff)
/source/blender/editors/space_graph/graph_utils.c (+10, -6) (Diff)
/source/blender/editors/space_graph/space_graph.c (+1, -1) (Diff)
/source/blender/editors/space_nla/nla_buttons.c (+2, -1) (Diff)
/source/blender/editors/space_nla/nla_channels.c (+4, -4) (Diff)
/source/blender/editors/space_nla/nla_draw.c (+2, -2) (Diff)
/source/blender/editors/space_nla/nla_edit.c (+22, -22) (Diff)
/source/blender/editors/space_nla/nla_select.c (+5, -4) (Diff)
/source/blender/editors/transform/transform_conversions.c (+9, -9) (Diff)
/source/blender/editors/transform/transform_generics.c (+2, -2) (Diff)